Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] breakdown PWDEBUG flags #5693

Closed
idoros opened this issue Mar 3, 2021 · 1 comment · Fixed by #6213
Closed

[Feature] breakdown PWDEBUG flags #5693

idoros opened this issue Mar 3, 2021 · 1 comment · Fixed by #6213
Assignees

Comments

@idoros
Copy link

idoros commented Mar 3, 2021

I was using PWDEBUG in order to preserve the developer tools settings as part of my workflow process. Over time the PWDEBUG introduced more setting, like the automatic opening of the new inspector and canceling the timeout.

The main thing that broke my flow was the x-pw-glass element injected by the inspector. The element cannot be toggled off even while the inspector is closed and causes my image snapshots to fail (I think it would be nice to somehow hide the x-pw-glass element from snapshots).

I wonder if those behaviors could be broken down into individuals environment variables?

@pavelfeldman
Copy link
Member

Makes sense. Note that the cancel timeout behavior has always been there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants