Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: dedup snapshot CSS images #7818

Closed
mxschmitt opened this issue Jul 23, 2021 · 2 comments · Fixed by #9731
Closed

[Bug]: dedup snapshot CSS images #7818

mxschmitt opened this issue Jul 23, 2021 · 2 comments · Fixed by #9731
Assignees
@JoelEinbinder @dgozman
Labels
feature-trace

Comments

@mxschmitt
Copy link
Member

mxschmitt commented Jul 23, 2021 •
edited
Loading

Reported by @Tallyb

This results in an enormous trace-file if the CSS images are large.
@pavelfeldman
Copy link
Member

(Note that this was due to greedy snapshotting of the shadow dom contents, we dedupe regular DOM attrs, but not the shadow ones).

@Tallyb
Copy link

Tallyb commented Jul 23, 2021

Pushing Playwright to the extreme....

@pavelfeldman pavelfeldman added v1.15 and removed v1.14 labels Aug 9, 2021
@mxschmitt mxschmitt assigned JoelEinbinder and unassigned mxschmitt Sep 7, 2021
@dgozman dgozman added v1.16 and removed v1.15 labels Sep 14, 2021
@mxschmitt mxschmitt added v1.17 and removed v1.16 labels Oct 12, 2021
@dgozman dgozman mentioned this issue Oct 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoelEinbinder JoelEinbinder

@dgozman dgozman

Labels
feature-trace
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(snapshot): empty adopted stylesheet should not prevent node refs dgozman/playwright
5 participants
@pavelfeldman @JoelEinbinder @Tallyb @dgozman @mxschmitt