Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory and performance tests for our browsers #977

Closed
JoelEinbinder opened this issue Feb 13, 2020 · 3 comments
Closed

Memory and performance tests for our browsers #977

JoelEinbinder opened this issue Feb 13, 2020 · 3 comments
Assignees

Comments

@JoelEinbinder
Copy link
Contributor

We should create standard benchmark to test memory usage, startup time, and cpu usage among all of our browsers and platforms. This will help us catch memory leaks, upstream performance regressions, and just in general have a better sense of how the browsers are doing.

As of right now I know our WebKit for Windows leaks memory. I'll continue to update this issue with more findings.

@JoelEinbinder JoelEinbinder self-assigned this Feb 13, 2020
@aslushnikov
Copy link
Collaborator

aslushnikov commented May 16, 2020

As of right now I know our WebKit for Windows leaks memory.

As of v1.0.0, I believe this is fixed.

We should create standard benchmark to test memory usage, startup time, and cpu usage among all of our browsers and platforms.

As of today, there are no plans to pursue this, so I'd close this for now.

@VikramTiwari
Copy link

Just piggybacking on this idea. I think this would be really helpful when folks are planning to provision VM instances for tests. If there are benchmarks, it helps understand how much time will be spent in the setup and thus can be the deciding factor between running tests in serial vs creating a new container for each test suite.

@barakplasma
Copy link

for what it's worth, when I run chromium via playwright in a 512mb limited docker container, it can't make a screenshot within 30 seconds. So I added a linux swap file of 4GB to the docker host, and that solved the issue for me (makes screenshots with no issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants