New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlobalDiscovery sample broken #64

Closed

JimDaly opened this issue Nov 12, 2019 · 1 comment

Assignees

Member

JimDaly commented Nov 12, 2019

The sample has a number of issues:

Failed to load using Visual Studio 2019, had to use VS 2017
There was a issue with the NugGet package where I had to click some Restore button to avoid build issues with VS 2017
The sample was recently updated here to replace the Authority URL.
Old value: https://login.windows.net/common
New value: https://login.microsoftonline.com

Sample wouldn't run until I switched back to the old value

This sample really ought to be updated to use the newer version of ADAL, then remove all the App.Config since this sample isn't using CrmServiceClient anyway.

JimDaly assigned Nkrb

Member

MattB-msft commented Nov 18, 2019

Addressed with this PR: #66 to remove the root issue

MattB-msft closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment