Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop date as an alternative to duration #11

Closed
erapade opened this issue Mar 18, 2017 · 3 comments
Closed

Stop date as an alternative to duration #11

erapade opened this issue Mar 18, 2017 · 3 comments

Comments

@erapade
Copy link

erapade commented Mar 18, 2017

Sometimes it's more convenient to specify a stop date-time instead of a duration. This stop date shall as the start date-time have a resolution of at least seconds. The code change is self is quite easy, and I have done it my self, but the trick is to define how this should be implemented in the GUI. Shall it be 1) a property setting defining if a value represents duration or stop time, or shall it be 2) two different fields where you can choose one (and only one) of them. Or 3) shall the current duration field be changed to Duration/StopTime and then the code determines if it's a duration or StopTime

My suggestion is (3) but I need some comments and maybe some code help for that since I'm far from native in java script

@ignatvilesov
Copy link
Contributor

ignatvilesov commented Apr 14, 2017

Hello @erapade

Thanks for your feedback.
I like the third option too.

Are you going to prepare a pull request soon? Otherwise, we'll include this ticket to our backlog and implement soon.

Ignat Vilesov,
Software Engineer

Microsoft Power BI Custom Visuals
pbicvsupport@microsoft.com

@erapade
Copy link
Author

erapade commented Mar 6, 2018

This is not relevant for me anymore. For others I guess a quick-measure would be able to do the same. If you are not going to implement this by your own interest, it's ok for me to close this request

@erapade
Copy link
Author

erapade commented May 2, 2019

looks like this is implemented since a while back now, so I will close this

@erapade erapade closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants