Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add visual name validation #96

Closed
jongio opened this issue May 10, 2017 · 7 comments
Closed

Please add visual name validation #96

jongio opened this issue May 10, 2017 · 7 comments

Comments

@jongio
Copy link

jongio commented May 10, 2017

pbiviz new 16test

throws this exception

C:\temp\pbiviz\16test2>pbiviz start
info   Building visual...
error  TYPESCRIPT   File 'C:/temp/pbiviz/16test2/node_modules/powerbi-visuals-utils-dataviewutils/lib/index.d.ts' not found.
error  TYPESCRIPT  /src/settings.ts : (27,36) '{' expected.
error  TYPESCRIPT  /src/settings.ts : (27,39) ';' expected.
error  TYPESCRIPT  /src/settings.ts : (27,39) Cannot find name 'test27A511107885F43A18DBC4378CA0E6737'.
error  TYPESCRIPT  /src/settings.ts : (27,78) ';' expected.
error  TYPESCRIPT  /src/settings.ts : (28,58) Property 'utils' does not exist on type 'typeof extensibility'.
error  TYPESCRIPT  /src/settings.ts : (28,58) Namespace 'powerbi.extensibility' has no exported member 'utils'.
error  TYPESCRIPT  /src/visual.ts : (27,36) '{' expected.
error  TYPESCRIPT  /src/visual.ts : (27,39) ';' expected.
error  TYPESCRIPT  /src/visual.ts : (27,39) Cannot find name 'test27A511107885F43A18DBC4378CA0E6737'.
error  TYPESCRIPT  /src/visual.ts : (27,78) ';' expected.
error  TYPESCRIPT  /src/visual.ts : (28,36) Cannot find name 'IVisual'.
error  TYPESCRIPT  /src/visual.ts : (31,27) Cannot find name 'VisualSettings'.
error  TYPESCRIPT  /src/visual.ts : (33,30) Cannot find name 'VisualConstructorOptions'.
error  TYPESCRIPT  /src/visual.ts : (39,32) Cannot find name 'VisualUpdateOptions'.
error  TYPESCRIPT  /src/visual.ts : (44,59) Cannot find name 'VisualSettings'.
error  TYPESCRIPT  /src/visual.ts : (45,20) Cannot find name 'VisualSettings'.
error  TYPESCRIPT  /src/visual.ts : (45,54) Cannot find name 'VisualSettings'.
error  TYPESCRIPT  /src/visual.ts : (55,50) Cannot find name 'EnumerateVisualObjectInstancesOptions'.
error  TYPESCRIPT  /src/visual.ts : (55,90) Cannot find name 'VisualObjectInstance'.
error  TYPESCRIPT  /src/visual.ts : (55,115) Cannot find name 'VisualObjectInstanceEnumerationObject'.
error  TYPESCRIPT  /src/visual.ts : (56,20) Cannot find name 'VisualSettings'.
error  TYPESCRIPT  /src/visual.ts : (56,77) Cannot find name 'VisualSettings'.
error  TYPESCRIPT  /visualPlugin.ts : (2,16) Variable declaration expected.
error  TYPESCRIPT  /visualPlugin.ts : (2,18) ';' expected.
error  TYPESCRIPT  /visualPlugin.ts : (2,18) Cannot find name 'test27A511107885F43A18DBC4378CA0E6737_DEBUG'.
error  TYPESCRIPT  /visualPlugin.ts : (8,103) Property 'visual' does not exist on type 'typeof extensibility'.
error  TYPESCRIPT  /visualPlugin.ts : (8,109) ',' expected.
error  TYPESCRIPT  /visualPlugin.ts : (8,112) ':' expected.
error  TYPESCRIPT  /visualPlugin.ts : (8,112) Cannot find name 'test27A511107885F43A18DBC4378CA0E6737'.
error  TYPESCRIPT  /visualPlugin.ts : (8,157) Cannot find name 'options'.

Please add name validation

@DiegoGLagash
Copy link

Same issue, also in OS X:

 info   Building visual...
 error  TYPESCRIPT   File '/[********]/Source/powerbi/labsVisual/node_modules/powerbi-visuals-utils-dataviewutils/lib/index.d.ts' not found.
 error  TYPESCRIPT  /src/settings.ts : (28,58) Property 'utils' does not exist on type 'typeof extensibility'.
 error  TYPESCRIPT  /src/settings.ts : (28,58) Namespace 'powerbi.extensibility' has no exported member 'utils'.
 error  TYPESCRIPT  /src/visual.ts : (45,35) Property 'parse' does not exist on type 'typeof VisualSettings'.
 error  TYPESCRIPT  /src/visual.ts : (56,35) Property 'enumerateObjectInstances' does not exist on type 'typeof VisualSettings'.
 error  TYPESCRIPT  /src/visual.ts : (56,92) Property 'getDefault' does not exist on type 'typeof VisualSettings'.

@dmoscatelli
Copy link

About the same issue as above

@richiepeters
Copy link

New to Node.JS, same issue, i have tried to get around this using the earlier version 4.3 of node.js - was not successful

@ignatvilesov
Copy link
Contributor

@jonbgallant 16test2 is an invalid JavaScript name. JavaScript doesn't allow to declare a variable that starts with a number. Please use this article to find out more about JavaScript variables

@DiegoGLagash Please execute npm install after you execute pbiviz new {VisualName}.

@richiepeters
Copy link

Thanks @ignatvilesov, legend.
I used this, just to clarify the steps to get starter were:

  1. pbiviz new {name}
  2. cd {dir to folder}
  3. npm install
  4. pbiviz start

@AviSander
Copy link
Member

in progress, thx.

@AviSander
Copy link
Member

done - thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants