Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Navigation loop - add go to runtime and back to studio #697

Merged
merged 17 commits into from Oct 3, 2023

Conversation

tyaginidhi
Copy link
Contributor

@tyaginidhi tyaginidhi commented Sep 14, 2023

Adding back to studio and go to runtime options in vscode web:
image

NOTE: About the runtime API being used here (same API as is being used in Studio) - this is what the Runtime team mentioned "It will make the 1st request a bit slow, no other impact unless its being called too often". Given this API has not caused issues so far in studio, even with a higher volume - this should have a low impact on runtime performance. Have added telemetry to gauge number and behavior around this.

@tyaginidhi tyaginidhi changed the title Users/nityagi/complete navigation loop Complete Navigation loop - add go to runtime and back to studio Sep 26, 2023
@tyaginidhi tyaginidhi marked this pull request as ready for review September 29, 2023 10:04
@tyaginidhi tyaginidhi requested a review from a team as a code owner September 29, 2023 10:04
package.json Show resolved Hide resolved
src/web/client/extension.ts Show resolved Hide resolved
@BidishaMS BidishaMS dismissed their stale review October 3, 2023 05:09

In future I am expecting small PRs

package.json Outdated Show resolved Hide resolved
@tyaginidhi tyaginidhi enabled auto-merge (squash) October 3, 2023 18:14
@tyaginidhi tyaginidhi merged commit d1b9a3b into main Oct 3, 2023
6 checks passed
@tyaginidhi tyaginidhi deleted the users/nityagi/CompleteNavigationLoop branch October 3, 2023 18:23
@tyaginidhi tyaginidhi mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants