Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent var/constant/parameter names in Convert.PermissionRule/Methods.ps1 #35

Closed
clcaldwell opened this issue Jul 20, 2018 · 0 comments · Fixed by #100
Closed
Assignees
Milestone

Comments

@clcaldwell
Copy link
Contributor

/Microsoft/PowerStig/Module/Convert.PermissionRule/Methods.ps1

'inheritance' and 'inheritence' are used interchangeably in the code, such as here:

$Inheritance = $script:inheritenceConstant[[string]$inheritance.trim()]

This will make it very difficult to modify these methods in the future.

Fix: All instances of 'inheritence' should be changed to 'inheritance'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants