Add logging for PowerRename (#14249)

* Add logging for PowerRename Move call tracer to common/utils/logger Add logging to both PowerRename dll and PowerRenameUIHost Add PowerRename to BugReportTool event viewer collection * Log more errors and exceptions
microsoft · Nov 8, 2021 · 079a3b4 · 079a3b4
1 parent c9dca68
commit 079a3b4
Show file tree

Hide file tree

Showing 16 changed files with 176 additions and 52 deletions.
diff --git a/...s/fancyzones/FancyZonesLib/CallTracer.cpp → src/common/logger/call_tracer.cpp b/...s/fancyzones/FancyZonesLib/CallTracer.cpp → src/common/logger/call_tracer.cpp
@@ -1,5 +1,7 @@
 #include "pch.h"
-#include "CallTracer.h"
+#include "call_tracer.h"
+
+#include <map>
 #include <thread>
 
 namespace

diff --git a/...les/fancyzones/FancyZonesLib/CallTracer.h → src/common/logger/call_tracer.h b/...les/fancyzones/FancyZonesLib/CallTracer.h → src/common/logger/call_tracer.h
@@ -1,6 +1,8 @@
 #pragma once
 
-#include "common/logger/logger.h"
+#include <string>
+
+#include "logger.h"
 
 #define _TRACER_ CallTracer callTracer(__FUNCTION__)
 

diff --git a/src/common/logger/logger.vcxproj b/src/common/logger/logger.vcxproj
@@ -31,12 +31,14 @@
     </ClCompile>
   </ItemDefinitionGroup>
   <ItemGroup>
+    <ClInclude Include="call_tracer.h" />
     <ClInclude Include="framework.h" />
     <ClInclude Include="logger.h" />
     <ClInclude Include="logger_settings.h" />
     <ClInclude Include="pch.h" />
   </ItemGroup>
   <ItemGroup>
+    <ClCompile Include="call_tracer.cpp" />
     <ClCompile Include="logger.cpp" />
     <ClCompile Include="logger_settings.cpp" />
     <ClCompile Include="pch.cpp">

diff --git a/src/common/logger/logger.vcxproj.filters b/src/common/logger/logger.vcxproj.filters
@@ -27,6 +27,9 @@
     <ClInclude Include="logger_settings.h">
       <Filter>Header Files</Filter>
     </ClInclude>
+    <ClInclude Include="call_tracer.h">
+      <Filter>Header Files</Filter>
+    </ClInclude>
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="logger.cpp">
@@ -38,6 +41,9 @@
     <ClCompile Include="logger_settings.cpp">
       <Filter>Source Files</Filter>
     </ClCompile>
+    <ClCompile Include="call_tracer.cpp">
+      <Filter>Source Files</Filter>
+    </ClCompile>
   </ItemGroup>
   <ItemGroup>
     <None Include="packages.config" />

diff --git a/src/common/logger/logger_settings.h b/src/common/logger/logger_settings.h
@@ -24,6 +24,7 @@ struct LogSettings
     inline const static std::string keyboardManagerLoggerName = "keyboard-manager";
     inline const static std::wstring keyboardManagerLogPath = L"Logs\\keyboard-manager-log.txt";
     inline const static std::string findMyMouseLoggerName = "find-my-mouse";
+    inline const static std::string powerRenameLoggerName = "powerrename";
     inline const static int retention = 30;
     std::wstring logLevel;
     LogSettings();

diff --git a/src/modules/fancyzones/FancyZonesLib/FancyZones.cpp b/src/modules/fancyzones/FancyZonesLib/FancyZones.cpp
@@ -4,6 +4,7 @@
 #include <common/display/dpi_aware.h>
 #include <common/interop/shared_constants.h>
 #include <common/logger/logger.h>
+#include <common/logger/call_tracer.h>
 #include <common/utils/EventWaiter.h>
 #include <common/utils/resources.h>
 #include <common/utils/winapi_error.h>
@@ -25,7 +26,6 @@
 #include "VirtualDesktop.h"
 #include "MonitorWorkAreaHandler.h"
 #include "util.h"
-#include "CallTracer.h"
 
 #include <FancyZonesLib/SecondaryMouseButtonsHook.h>
 #include <winrt/Windows.UI.ViewManagement.h>

diff --git a/src/modules/fancyzones/FancyZonesLib/FancyZonesData.cpp b/src/modules/fancyzones/FancyZonesLib/FancyZonesData.cpp
@@ -4,10 +4,10 @@
 #include "JsonHelpers.h"
 #include "ZoneSet.h"
 #include "Settings.h"
-#include "CallTracer.h"
 #include "GuidUtils.h"
 
 #include <common/Display/dpi_aware.h>
+#include <common/logger/call_tracer.h>
 #include <common/utils/json.h>
 #include <FancyZonesLib/util.h>
 #include <FancyZonesLib/FancyZonesWindowProperties.h>

diff --git a/src/modules/fancyzones/FancyZonesLib/FancyZonesLib.vcxproj b/src/modules/fancyzones/FancyZonesLib/FancyZonesLib.vcxproj
@@ -37,7 +37,6 @@
     </ClCompile>
   </ItemDefinitionGroup>
   <ItemGroup>
-    <ClInclude Include="CallTracer.h" />
     <ClInclude Include="FancyZones.h" />
     <ClInclude Include="FancyZonesDataTypes.h" />
     <ClInclude Include="FancyZonesWinHookEventIDs.h" />
@@ -65,7 +64,6 @@
     <ClInclude Include="ZoneWindowDrawing.h" />
   </ItemGroup>
   <ItemGroup>
-    <ClCompile Include="CallTracer.cpp" />
     <ClCompile Include="FancyZones.cpp" />
     <ClCompile Include="FancyZonesDataTypes.cpp" />
     <ClCompile Include="FancyZonesWinHookEventIDs.cpp" />

diff --git a/src/modules/fancyzones/FancyZonesLib/FancyZonesLib.vcxproj.filters b/src/modules/fancyzones/FancyZonesLib/FancyZonesLib.vcxproj.filters
@@ -78,9 +78,6 @@
     <ClInclude Include="ZoneWindowDrawing.h">
       <Filter>Header Files</Filter>
     </ClInclude>
-    <ClInclude Include="CallTracer.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
     <ClInclude Include="MonitorUtils.h">
       <Filter>Header Files</Filter>
     </ClInclude>
@@ -149,9 +146,6 @@
     <ClCompile Include="OnThreadExecutor.cpp">
       <Filter>Source Files</Filter>
     </ClCompile>
-    <ClCompile Include="CallTracer.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
     <ClCompile Include="MonitorUtils.cpp">
       <Filter>Source Files</Filter>
     </ClCompile>

diff --git a/src/modules/fancyzones/FancyZonesLib/OnThreadExecutor.cpp b/src/modules/fancyzones/FancyZonesLib/OnThreadExecutor.cpp
@@ -1,7 +1,8 @@
 #include "pch.h"
 
+#include <common/logger/call_tracer.h>
+
 #include "on_thread_executor.h"
-#include "CallTracer.h"
 
 OnThreadExecutor::OnThreadExecutor() :
     _shutdown_request{ false }, _worker_thread{ [this] { worker_thread(); } }

diff --git a/src/modules/fancyzones/FancyZonesLib/WorkArea.cpp b/src/modules/fancyzones/FancyZonesLib/WorkArea.cpp
@@ -1,6 +1,7 @@
 #include "pch.h"
 #include "WorkArea.h"
 
+#include <common/logger/call_tracer.h>
 #include <common/logger/logger.h>
 
 #include "FancyZonesData.h"
@@ -10,7 +11,6 @@
 #include "util.h"
 #include "on_thread_executor.h"
 #include "Settings.h"
-#include "CallTracer.h"
 
 #include <ShellScalingApi.h>
 #include <mutex>

diff --git a/src/modules/fancyzones/FancyZonesLib/ZoneWindowDrawing.cpp b/src/modules/fancyzones/FancyZonesLib/ZoneWindowDrawing.cpp
@@ -1,12 +1,12 @@
 #include "pch.h"
 #include "ZoneWindowDrawing.h"
-#include "CallTracer.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 #include <vector>
 
+#include <common/logger/call_tracer.h>
 #include <common/logger/logger.h>
 
 namespace