PowerToys Settings and OOBE title localization (#10054)

microsoft · Mar 5, 2021 · 11c622a · 11c622a
1 parent 22429b2
commit 11c622a
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 2 deletions.
diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/Strings/en-us/Resources.resw b/src/settings-ui/Microsoft.PowerToys.Settings.UI/Strings/en-us/Resources.resw
@@ -1145,4 +1145,10 @@ Win + Shift + O to toggle your video</value>
   <data name="Oobe_Button.Text" xml:space="preserve">
     <value>Welcome to PowerToys</value>
   </data>
+  <data name="OobeWindow_Title" xml:space="preserve">
+    <value>Welcome to PowerToys</value>
+  </data>
+  <data name="SettingsWindow_Title" xml:space="preserve">
+    <value>PowerToys Settings</value>
+  </data>
 </root>
diff --git a/src/settings-ui/PowerToys.Settings/MainWindow.xaml b/src/settings-ui/PowerToys.Settings/MainWindow.xaml
@@ -7,7 +7,6 @@
         xmlns:Controls="clr-namespace:Microsoft.Toolkit.Wpf.UI.Controls;assembly=Microsoft.Toolkit.Wpf.UI.Controls"
         xmlns:xaml="clr-namespace:Microsoft.Toolkit.Wpf.UI.XamlHost;assembly=Microsoft.Toolkit.Wpf.UI.XamlHost"
         mc:Ignorable="d"
-        Title="PowerToys Settings"
         Height="860"
         MinHeight="400"
         Width="1180"

diff --git a/src/settings-ui/PowerToys.Settings/MainWindow.xaml.cs b/src/settings-ui/PowerToys.Settings/MainWindow.xaml.cs
@@ -9,6 +9,7 @@
 using Microsoft.PowerToys.Settings.UI.Views;
 using Microsoft.PowerToys.Telemetry;
 using Microsoft.Toolkit.Wpf.UI.XamlHost;
+using Windows.ApplicationModel.Resources;
 using Windows.Data.Json;
 
 namespace PowerToys.Settings
@@ -29,6 +30,9 @@ public MainWindow()
 
             Utils.FitToScreen(this);
 
+            ResourceLoader loader = ResourceLoader.GetForViewIndependentUse();
+            Title = loader.GetString("SettingsWindow_Title");
+
             bootTime.Stop();
 
             PowerToysTelemetry.Log.WriteEvent(new SettingsBootEvent() { BootTimeMs = bootTime.ElapsedMilliseconds });

diff --git a/src/settings-ui/PowerToys.Settings/OobeWindow.xaml b/src/settings-ui/PowerToys.Settings/OobeWindow.xaml
@@ -7,7 +7,6 @@
         xmlns:Controls="clr-namespace:Microsoft.Toolkit.Wpf.UI.Controls;assembly=Microsoft.Toolkit.Wpf.UI.Controls"
         xmlns:xaml="clr-namespace:Microsoft.Toolkit.Wpf.UI.XamlHost;assembly=Microsoft.Toolkit.Wpf.UI.XamlHost"
         mc:Ignorable="d"
-        Title="Welcome to PowerToys"
         MinWidth="480" Height="700" Width="1100"
         ResizeMode="NoResize"
         WindowStartupLocation="CenterScreen"

diff --git a/src/settings-ui/PowerToys.Settings/OobeWindow.xaml.cs b/src/settings-ui/PowerToys.Settings/OobeWindow.xaml.cs
@@ -8,6 +8,7 @@
 using Microsoft.PowerToys.Settings.UI.Helpers;
 using Microsoft.PowerToys.Settings.UI.OOBE.Views;
 using Microsoft.Toolkit.Wpf.UI.XamlHost;
+using Windows.ApplicationModel.Resources;
 
 namespace PowerToys.Settings
 {
@@ -31,6 +32,9 @@ public OobeWindow()
         {
             InitializeComponent();
             Utils.FitToScreen(this);
+
+            ResourceLoader loader = ResourceLoader.GetForViewIndependentUse();
+            Title = loader.GetString("OobeWindow_Title");
         }
 
         private void Window_Closed(object sender, EventArgs e)