-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding privacy event tags to each telemetry event. (#2879)
* Adding privacy event tags to each telemetry event. * Moving Privacy events to Telemetry base, Removing tag values, and fixing namespaces. * Adding documentation comments to fix style cop errors in release * UTCReplace_AppSessionGuid boolean property to all C# telemetry events. * Adding hardcoded version number to boot events. * Adding reference to telemetry in settings unittest * Adding Preview Pane events for loading w/ hardcoded version number * Adding telemetry.h to msi for svg and markdown events * removing unused explicit interface exception
- Loading branch information
1 parent
d4b56f9
commit 34f8147
Showing
34 changed files
with
505 additions
and
354 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Diagnostics.Tracing; | ||
using System.Text; | ||
|
||
namespace Microsoft.PowerToys.Telemetry.Events | ||
{ | ||
/// <summary> | ||
/// A base class to implement properties that are common to all telemetry events. | ||
/// </summary> | ||
[EventData] | ||
public class EventBase | ||
{ | ||
public bool UTCReplace_AppSessionGuid => true; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Text; | ||
|
||
namespace Microsoft.PowerToys.Telemetry.Events | ||
{ | ||
public interface IEvent | ||
{ | ||
PartA_PrivTags PartA_PrivTags { get; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
|
||
<PropertyGroup> | ||
<Platforms>x64</Platforms> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
src/core/Microsoft.PowerToys.Settings.UI.Lib/Telemetry/Events/SettingsBootEvent.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// Copyright (c) Microsoft Corporation | ||
// The Microsoft Corporation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System.Diagnostics.Tracing; | ||
using Microsoft.PowerToys.Telemetry; | ||
using Microsoft.PowerToys.Telemetry.Events; | ||
|
||
namespace Microsoft.PowerLauncher.Telemetry | ||
{ | ||
[EventData] | ||
public class SettingsBootEvent : EventBase, IEvent | ||
{ | ||
/// <summary> | ||
/// Gets The version string. TODO: This should be replaced by a P/Invoke call to get_product_version | ||
/// </summary> | ||
public string Version => "v0.18.0"; | ||
|
||
public double BootTimeMs { get; set; } | ||
|
||
public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServicePerformance; | ||
} | ||
} |
6 changes: 5 additions & 1 deletion
6
src/core/Microsoft.PowerToys.Settings.UI.Lib/Telemetry/Events/SettingsEnabledEvent.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,16 @@ | ||
using System.Diagnostics.Tracing; | ||
using Microsoft.PowerToys.Telemetry; | ||
using Microsoft.PowerToys.Telemetry.Events; | ||
|
||
namespace Microsoft.PowerToys.Settings.Telemetry | ||
{ | ||
[EventData] | ||
public class SettingsEnabledEvent | ||
public class SettingsEnabledEvent : EventBase, IEvent | ||
{ | ||
public string Name { get; set; } | ||
|
||
public bool Value { get; set; } | ||
|
||
public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.