Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update pull_request_template.md (#17891)
* Update pull_request_template.md * Update .github/pull_request_template.md Co-authored-by: Aaron Junker <aaron.junker@outlook.com> * Update pull_request_template.md Co-authored-by: Aaron Junker <aaron.junker@outlook.com>
- Loading branch information
1 parent
d9e8b3e
commit 35c1438
Showing
1 changed file
with
18 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,24 @@ | ||
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> | ||
## Summary of the Pull Request | ||
|
||
**What is this about:** | ||
<!-- Please review the items on the PR checklist before submitting--> | ||
## PR Checklist | ||
|
||
**What is included in the PR:** | ||
|
||
**How does someone test / validate:** | ||
|
||
## Quality Checklist | ||
|
||
- [ ] **Linked issue:** #xxx | ||
- [ ] **Communication:** I've discussed this with core contributors in the issue. | ||
- [ ] **Closes:** #xxx | ||
- [ ] **Communication:** I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected | ||
- [ ] **Tests:** Added/updated and all pass | ||
- [ ] **Installer:** Added/updated and all pass | ||
- [ ] **Localization:** All end user facing strings can be localized | ||
- [ ] **Docs:** Added/ updated | ||
- [ ] **Binaries:** Any new files are added to WXS / YML | ||
- [ ] No new binaries | ||
- [ ] [YML for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/pipeline.user.windows.yml#L68) for new binaries | ||
- [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries | ||
- [ ] **Dev docs:** Added/updated | ||
- [ ] **New binaries:** Added on the required places | ||
- [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries | ||
- [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder | ||
- [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects | ||
- [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) | ||
- [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx | ||
|
||
<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> | ||
## Detailed Description of the Pull Request / Additional comments | ||
|
||
<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> | ||
## Validation Steps Performed | ||
|
||
## Contributor License Agreement (CLA) | ||
A CLA must be signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/PowerToys) and sign the CLA. |