Fixing potentially infinite loop with logs in Color Picker (#5558)

microsoft · Aug 4, 2020 · 76ab389 · 76ab389
1 parent d323611
commit 76ab389
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/modules/colorPicker/ColorPickerUI/Helpers/Logger.cs b/src/modules/colorPicker/ColorPickerUI/Helpers/Logger.cs
@@ -64,7 +64,7 @@ private static string GetCallerInfo()
 
             var methodName = stackTrace.GetFrame(3)?.GetMethod();
             var className = methodName?.DeclaringType.Name;
-            return "[Method]: " + methodName.Name + " [Class]: " + className;
+            return "[Method]: " + methodName?.Name + " [Class]: " + className;
         }
     }
 }
diff --git a/src/modules/colorPicker/ColorPickerUI/Settings/UserSettings.cs b/src/modules/colorPicker/ColorPickerUI/Settings/UserSettings.cs
@@ -78,7 +78,13 @@ private void LoadSettingsFromJson()
                         }
                         catch (Exception ex)
                         {
+                            if (retryCount > MaxNumberOfRetry)
+                            {
+                                retry = false;
+                            }
+
                             Logger.LogError("Failed to read changed settings", ex);
+                            Thread.Sleep(500);
                         }
                     }
                 };