[Telemetry] Fix show hide events on PT Run cold boot (#12796)

* [Telemetry] fix show hide events on PT Run boot * Fix spellchecker error
microsoft · Aug 18, 2021 · 8639740 · 8639740
1 parent 784a464
commit 8639740
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 9 deletions.
diff --git a/src/modules/launcher/PowerLauncher/MainWindow.xaml.cs b/src/modules/launcher/PowerLauncher/MainWindow.xaml.cs
@@ -116,6 +116,7 @@ private void OnLoaded(object sender, RoutedEventArgs e)
             ListBox.SuggestionsList.PreviewMouseLeftButtonUp += SuggestionsList_PreviewMouseLeftButtonUp;
             _viewModel.PropertyChanged += ViewModel_PropertyChanged;
             _viewModel.MainWindowVisibility = Visibility.Collapsed;
+            _viewModel.LoadedAtLeastOnce = true;
 
             BringProcessToForeground();
         }

diff --git a/src/modules/launcher/PowerLauncher/ViewModel/MainViewModel.cs b/src/modules/launcher/PowerLauncher/ViewModel/MainViewModel.cs
@@ -376,6 +376,8 @@ private ResultsViewModel SelectedResults
             }
         }
 
+        public bool LoadedAtLeastOnce { get; set; }
+
         private Visibility _visibility;
 
         public Visibility MainWindowVisibility
@@ -390,16 +392,20 @@ public Visibility MainWindowVisibility
                 if (_visibility != value)
                 {
                     _visibility = value;
-                    OnPropertyChanged(nameof(MainWindowVisibility));
-                }
+                    if (LoadedAtLeastOnce)
+                    {
+                        // Don't trigger telemetry on cold boot. Must have been loaded at least once.
+                        if (value == Visibility.Visible)
+                        {
+                            PowerToysTelemetry.Log.WriteEvent(new LauncherShowEvent());
+                        }
+                        else
+                        {
+                            PowerToysTelemetry.Log.WriteEvent(new LauncherHideEvent());
+                        }
+                    }
 
-                if (value == Visibility.Visible)
-                {
-                    PowerToysTelemetry.Log.WriteEvent(new LauncherShowEvent());
-                }
-                else
-                {
-                    PowerToysTelemetry.Log.WriteEvent(new LauncherHideEvent());
+                    OnPropertyChanged(nameof(MainWindowVisibility));
                 }
             }
         }