Fixed some minor code styling issues. Removed some minor redundant ca…

…lculations for a small performance enhancement with zone detection.
microsoft · Sep 26, 2019 · a8f0d32 · a8f0d32
1 parent af67f77
commit a8f0d32
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/src/modules/fancyzones/lib/ZoneSet.cpp b/src/modules/fancyzones/lib/ZoneSet.cpp
@@ -78,26 +78,31 @@ IFACEMETHODIMP ZoneSet::RemoveZone(winrt::com_ptr<IZone> zone) noexcept
 IFACEMETHODIMP_(winrt::com_ptr<IZone>) ZoneSet::ZoneFromPoint(POINT pt) noexcept
 {
     winrt::com_ptr<IZone> smallestKnownZone = nullptr;
+    // To reduce redundant calculations, we will store the last known zones area.
+    int smallestKnownZoneArea = INT32_MAX;
     for (auto iter = m_zones.begin(); iter != m_zones.end(); iter++)
     {
         if (winrt::com_ptr<IZone> zone = iter->try_as<IZone>())
         {
             RECT* newZoneRect = &zone->GetZoneRect();
             if (PtInRect(newZoneRect, pt))
             {
-                if(smallestKnownZone == nullptr)
+                if (smallestKnownZone == nullptr)
                 {
                     smallestKnownZone = zone;
+
+                    RECT* r = &smallestKnownZone->GetZoneRect();
+                    smallestKnownZoneArea = (r->right-r->left)*(r->bottom-r->top);
                 }
                 else
                 {
-                    RECT* r = &smallestKnownZone->GetZoneRect();
-                    int knownZoneArea = (r->right-r->left)*(r->bottom-r->top);
-
                     int newZoneArea = (newZoneRect->right-newZoneRect->left)*(newZoneRect->bottom-newZoneRect->top);
 
-                    if(newZoneArea<knownZoneArea)
+                    if (newZoneArea<smallestKnownZoneArea)
+                    {
                         smallestKnownZone = zone;
+                        newZoneArea = smallestKnownZoneArea;
+                    }
                 }
             }
         }