[PTRun][WebSearch]Fix empty browser pattern crash (#18480)

microsoft · May 25, 2022 · a9181a0 · a9181a0
1 parent f9e9679
commit a9181a0
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/modules/launcher/Wox.Infrastructure/Helper.cs b/src/modules/launcher/Wox.Infrastructure/Helper.cs
@@ -150,7 +150,11 @@ public static Process OpenInConsole(string path)
 
         public static bool OpenCommandInShell(string path, string pattern, string arguments, string workingDir = null, ShellRunAsType runAs = ShellRunAsType.None, bool runWithHiddenWindow = false)
         {
-            if (pattern.Contains("%1", StringComparison.Ordinal))
+            if (string.IsNullOrEmpty(pattern))
+            {
+                Log.Warn("Trying to run OpenCommandInShell with an empty pattern. The default browser definition might have issues.", typeof(Helper));
+            }
+            else if (pattern.Contains("%1", StringComparison.Ordinal))
             {
                 arguments = pattern.Replace("%1", arguments);
             }