[PTRun]Fix always hiding even when an action fails (#21259)

Hide PowerToys Run if the result action returns true, otherwise keep it open
microsoft · Oct 25, 2022 · aa6910a · aa6910a
1 parent 778bb7a
commit aa6910a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/modules/launcher/PowerLauncher/ViewModel/MainViewModel.cs b/src/modules/launcher/PowerLauncher/ViewModel/MainViewModel.cs
@@ -192,16 +192,21 @@ private void OpenResultsEvent(object index, bool isMouseClick)
                     // SelectedItem returns null if selection is empty.
                     if (result != null && result.Action != null)
                     {
-                        Hide();
+                        bool hideWindow = true;
 
                         Application.Current.Dispatcher.Invoke(() =>
                         {
-                            result.Action(new ActionContext
+                            hideWindow = result.Action(new ActionContext
                             {
                                 SpecialKeyState = KeyboardHelper.CheckModifiers(),
                             });
                         });
 
+                        if (hideWindow)
+                        {
+                            Hide();
+                        }
+
                         if (SelectedIsFromQueryResults())
                         {
                             _userSelectedRecord.Add(result);

diff --git a/src/modules/launcher/Wox.Plugin/Result.cs b/src/modules/launcher/Wox.Plugin/Result.cs
@@ -103,7 +103,8 @@ public string IcoPath
         public IconDelegate Icon { get; set; }
 
         /// <summary>
-        /// Gets or sets return true to hide wox after select result
+        /// Gets or sets the result action.
+        /// Return <c>true</c> to hide PowerToys Run after the result has been selected.
         /// </summary>
         [JsonIgnore]
         public Func<ActionContext, bool> Action { get; set; }