Skip to content

Commit

Permalink
[VCM] disable reencoding if not using explicit debug flag
Browse files Browse the repository at this point in the history
  • Loading branch information
@yuyoyuppe
yuyoyuppe committed Apr 14, 2021
1 parent ca8bf43 commit e8eb932
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/modules/videoconference/VideoConferenceProxyFilter/VideoCaptureProxyFilter.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,7 @@ bool OverwriteFrame(IMediaSample* frame, wil::com_ptr_nothrow<IMFSample>& image)

//#define DEBUG_FRAME_DATA
//#define DEBUG_OVERWRITE_FRAME
//#define DEBUG_REENCODE_JPG_DATA

#if defined(DEBUG_OVERWRITE_FRAME)
void DebugOverwriteFrame(IMediaSample* frame, std::string_view filepath)
Expand Down Expand Up @@ -588,6 +589,7 @@ VideoCaptureProxyFilter::VideoCaptureProxyFilter() :
DebugOverwriteFrame(_pending_frame, "R:\\frame.data");
#endif
}
#if defined(DEBUG_REENCODE_JPG_DATA)
else
{
GUID subtype{};
Expand All @@ -597,6 +599,7 @@ VideoCaptureProxyFilter::VideoCaptureProxyFilter() :
ReencodeFrame(_pending_frame);
}
}
#endif

_pending_frame = nullptr;
input->Receive(sample);
Expand Down

2 comments on commit e8eb932

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspellings found, please review:

  • filepath
  • reencode
  • reencoded
  • seekg
  • streampos
  • tellg
To accept these changes, run the following commands from this repository on this branch 
pushd $(git rev-parse --show-toplevel)
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spell-check";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"filepath reencode reencoded seekg streampos tellg "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspellings found, please review:

  • filepath
  • reencode
  • reencoded
  • seekg
  • streampos
  • tellg
To accept these changes, run the following commands from this repository on this branch 
pushd $(git rev-parse --show-toplevel)
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spell-check";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"filepath reencode reencoded seekg streampos tellg "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

Please sign in to comment.