Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Advanced Paste] "Configure OpenAI Key" is hardcoded and not localized #33139

Closed
zetaloop opened this issue May 29, 2024 · 7 comments
Closed
Assignees
Labels
Area-Localization issues regarding to Localization the application Area-User Interface things that regard UX for PowerToys Issue-Bug Something isn't working Product-Advanced Paste Refers to the Advanced Paste module Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@zetaloop
Copy link
Contributor

Microsoft PowerToys version

0.81.1

Installation method

GitHub

Running as admin

None

Area(s) with issue?

Advanced Paste, Settings

Steps to reproduce

Enable Paste with AI in PT Settings.

Snipaste_2024-05-29_14-01-13

✔️ Expected Behavior

Configure OpenAI Key should be localized.
For example, 配置 OpenAI 密钥 in Chinese.

❌ Actual Behavior

Even worse, it is hardcoded.

<TextBlock FontWeight="SemiBold" Text="Configure OpenAI key" />

Other Software

No response

@zetaloop zetaloop added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels May 29, 2024
@htcfreek htcfreek added Area-Localization issues regarding to Localization the application Status-In progress This issue or work-item is under development Area-User Interface things that regard UX for PowerToys Product-Advanced Paste Refers to the Advanced Paste module and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels May 29, 2024
@francisco-lafe
Copy link

Of course it's hardcoded, also the fact that you can only use OpenAI, despite existing competitors.
I guess we're now on the extend and extinguish phase. Gotta make the investment worth it 👍

@AkazaRenn
Copy link

AkazaRenn commented May 29, 2024

Of course it's hardcoded, also the fact that you can only use OpenAI, despite existing competitors.
I guess we're now on the extend and extinguish phase. Gotta make the investment worth it 👍

I don't think you understand this issue. This is able LOCALIZATION where the aforementioned string needs to be TRANSLATED into the language the user uses.

@zetaloop
Copy link
Contributor Author

zetaloop commented May 30, 2024

Of course it's hardcoded, also the fact that you can only use OpenAI, despite existing competitors.
I guess we're now on the extend and extinguish phase. Gotta make the investment worth it 👍

I don't think I understand this issue. This is able LOCALIZATION where the aforementioned string needs to be TRANSLATED into the language the user uses.

Yes. The issue is that "Configure OpenAI Key" is hardcoded in the XAML file. To localize it properly, we need to move this string to the resource files (resw).

@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jun 4, 2024
@jaimecbernardo jaimecbernardo added this to the PowerToys 0.82 milestone Jun 4, 2024
@zetaloop zetaloop closed this as completed Jun 4, 2024
@htcfreek
Copy link
Collaborator

htcfreek commented Jun 8, 2024

@jaimecbernardo
Please reopen.

@zetaloop
Copy link
Contributor Author

zetaloop commented Jun 8, 2024

@jaimecbernardo Please reopen.

Could you please let me know why to reopen? It seems that the problem has already been resolved in #33140.

@zetaloop zetaloop reopened this Jun 8, 2024
@htcfreek
Copy link
Collaborator

htcfreek commented Jun 8, 2024

@jaimecbernardo Please reopen.

Could you please let me know why to reopen? It seems that the problem has already been resolved in #33140.

We close the issues after the fix/change is released. (It's an organization thing.)

@htcfreek
Copy link
Collaborator

htcfreek commented Jul 9, 2024

This was released wit v0.82.0.

@htcfreek htcfreek closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Localization issues regarding to Localization the application Area-User Interface things that regard UX for PowerToys Issue-Bug Something isn't working Product-Advanced Paste Refers to the Advanced Paste module Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

5 participants