Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Unmapped Faker Entity Types #68

Open
Robbie-Palmer opened this issue Jan 10, 2023 · 0 comments
Open

Handle Unmapped Faker Entity Types #68

Robbie-Palmer opened this issue Jan 10, 2023 · 0 comments

Comments

@Robbie-Palmer
Copy link
Contributor

Robbie-Palmer commented Jan 10, 2023

Suggested by @melmatlis in #50 (comment)

To avoid the library breaking when faker adds new entity types

"Perhaps we can add to the faker_to_presidio mapping an additional default value 'other' for cases when a new unmapped key appears, then the mapping will become:"

                span.type = self.faker_to_presidio_entity_type.get(span.type,'other')

These unknown types would also need tracked and replaced in the template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant