Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand deployment rules to include pods and replica sets #13

Closed
BernieWhite opened this issue Aug 12, 2019 · 0 comments · Fixed by #22
Closed

Expand deployment rules to include pods and replica sets #13

BernieWhite opened this issue Aug 12, 2019 · 0 comments · Fixed by #22
Assignees
@BernieWhite
Labels
rule The issue relates to a rule
Milestone
v0.1.0

Comments

@BernieWhite
Copy link
Member

BernieWhite commented Aug 12, 2019 •
edited

The Kubernetes.Deployment.PrivilegeEscalation, Kubernetes.Deployment.NotLatestImage and Kubernetes.Deployment.ResourcesSet rules relate to pod spec configuration.

These rules should include standalone pods and replica sets that are not created using a deployment.

We should avoid flagging pods that are in a replica set or pods in a deployment (which also creates a replica set).

So, flag a deployment, or a standalone replica set, or a standalone pod.

This is also related to #12.
@BernieWhite BernieWhite added the enhancement New feature or request label Aug 12, 2019
@BernieWhite BernieWhite added this to the v0.1.0 milestone Aug 12, 2019
@BernieWhite BernieWhite self-assigned this Aug 12, 2019
@BernieWhite BernieWhite added rule The issue relates to a rule and removed enhancement New feature or request labels Aug 12, 2019
BernieWhite added a commit that referenced this issue Dec 23, 2019
@BernieWhite
Update deployment rules #13 #12 #5 #18 #19 #20 #21
2bdf91e
@BernieWhite BernieWhite mentioned this issue Dec 23, 2019
Merged
7 tasks
BernieWhite added a commit that referenced this issue Dec 23, 2019
@BernieWhite
Update deployment rules #13 #12 #5 #18 #19 #20 #21 (#22)
2477880
@BernieWhite BernieWhite mentioned this issue Dec 23, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BernieWhite BernieWhite

Labels
rule The issue relates to a rule
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Update deployment rules #13 #12 #5 #18 #19 #20 #21 microsoft/PSRule.Rules.Kubernetes
1 participant
@BernieWhite