Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Test-PSRule to Test-PSRuleTarget #57

Closed
BernieWhite opened this issue Jan 14, 2019 · 0 comments
Closed

Rename Test-PSRule to Test-PSRuleTarget #57

BernieWhite opened this issue Jan 14, 2019 · 0 comments
Assignees
@BernieWhite
Labels
enhancement New feature or request
Milestone
v0.2.0

Comments

@BernieWhite
Copy link
Member

BernieWhite commented Jan 14, 2019 •
edited

Description of the issue

Test-PSRule was introduced in pre-release 0.2.0-B190105. PowerShell cmdlets are named with a standard naming convention using verb-noun.

Test-PSRule should be renamed to Test-PSRuleTarget. While Test-PSRule is shorter, it doesn't accurately reflect the noun or subject of the test. The subject of the test is the target object not the rule.

Module in use and version:

  • Module: PSRule
  • Version: 0.2.0-B190105
@BernieWhite BernieWhite added the enhancement New feature or request label Jan 14, 2019
@BernieWhite BernieWhite added this to the v0.2.0 milestone Jan 14, 2019
@BernieWhite BernieWhite self-assigned this Jan 14, 2019
BernieWhite added a commit that referenced this issue Jan 14, 2019
@BernieWhite
Update change log #57
49f33a6
@BernieWhite BernieWhite mentioned this issue Jan 14, 2019
Merged
7 tasks
BernieWhite added a commit that referenced this issue Jan 14, 2019
@BernieWhite
Rename Test-PSRule to Test-PSRuleTarget #57 (#58)
9157b5f 
- Rename Test-PSRule to Test-PSRuleTarget #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BernieWhite BernieWhite

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@BernieWhite