Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Refactor branch: updates needed to support os.fork #1687

Closed
karthiknadig opened this issue Aug 12, 2019 · 3 comments
Closed

Refactor branch: updates needed to support os.fork #1687

karthiknadig opened this issue Aug 12, 2019 · 3 comments
Labels
Milestone

Comments

@karthiknadig
Copy link
Member

  1. settrace_forked should use settings similar to settrace in _enable_attach
wait_for_ready_to_run=False,
block_until_connected=False,
  1. forked processes should notify parent about the port to communicate on.
  2. forked processes should wait for a response from parent on should they continue or not.
@karthiknadig
Copy link
Member Author

karthiknadig commented Aug 12, 2019

We will also need to update _on_forked_process so that the forked process can connect to parent process, since it wont receive the host and port via CLI.

@karthiknadig karthiknadig added this to the August 2019.2 milestone Aug 19, 2019
@karthiknadig
Copy link
Member Author

We decided we want to take a common approach for os.spawn and os.fork sub-processes. we will update here when we have settled on a design.

@karthiknadig
Copy link
Member Author

Closing this in favor of the epic we have to handle multiprocessing: #1706

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant