Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

pydevd: explicit host/port for subprocesses to connect to #1707

Closed
int19h opened this issue Aug 21, 2019 · 1 comment
Closed

pydevd: explicit host/port for subprocesses to connect to #1707

int19h opened this issue Aug 21, 2019 · 1 comment
Assignees
Milestone

Comments

@int19h
Copy link
Contributor

int19h commented Aug 21, 2019

When pydevd detects a child process spawn and detours it, the child process currently connects to the same socket to which the parent process was connected.

To support #1706 in enable_attach() scenarios, the child process needs to be able to connect to a host/port that is explicitly specified, and not assumed to be the same.

The parent process will receive this information via a new property in the "launch" or "attach" request, e.g.:

"subProcesses": {
  "clientHost": "127.0.0.1",
  "clientPort": 7944,
}

(We'll use this property to aggregate all information that needs to be communicated to the parent about how it should handle the children, to avoid proliferation of top-level properties in debug config.)

It should propagate this information to the child process by whatever means are appropriate for the API used to spawn it - that part is considered pydevd implementation detail.

@fabioz
Copy link
Contributor

fabioz commented Aug 22, 2019

Note: on hold (waiting for e-mail feedback).

@karthiknadig karthiknadig added this to the Aug 2019.2 milestone Aug 22, 2019
@fabioz fabioz closed this as completed Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants