Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Move ptvsd_launcher.py into this repo #41

Closed
DonJayamanne opened this issue Feb 6, 2018 · 4 comments
Closed

Move ptvsd_launcher.py into this repo #41

DonJayamanne opened this issue Feb 6, 2018 · 4 comments
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Feb 6, 2018

VS Code would like to use the ptvsd_launcher.py file (found in VS) to launch the debugger.

This allows VS Code to share the logic found in the above script.

Based on conversation with Pavel here #40 (comment)

@karthiknadig Once this is done you'll need to update VS accordingly.

@DonJayamanne
Copy link
Contributor Author

Should the same be done for the other ptvsd_* scripts?
Namely:

  • ptvsd_loader.py
  • ptvsd_repl_launcher.py

@int19h
Copy link
Contributor

int19h commented Feb 6, 2018

Loader is only used for direct local attach via thread injection; pydevd has its own way of doing this which is different (and which we still need to investigate).

The REPL script is for the REPL Python backend in the old debugger (that talks its own protocol). We might need something to replace it for REPL, but it definitely won't be the same script.

@int19h int19h added this to the VSC Stable milestone Mar 21, 2018
@brettcannon
Copy link
Member

Been told by @DonJayamanne this has been done.

@DonJayamanne
Copy link
Contributor Author

Fixed with microsoft/vscode-python#1373

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants