Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary assets do not appear in asset editor after changing the color palette in Horse Race game #5650

Open
kimprice opened this issue Feb 2, 2023 · 1 comment
Assignees
Labels
asset editor bug Something isn't working p2

Comments

@kimprice
Copy link
Member

kimprice commented Feb 2, 2023

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://arcade.makecode.com/
  2. Scroll down to Multiplayer Games, click on "Horse Race" and then "Open in Editor"
  3. Go to the Asset Editor and click on "Colors"
  4. Change the color palette and click "Apply"
  5. See the temporary assets no longer appear in the Asset Editor

Screenshots
tempAssets2

Additional context
I have not been able to reproduce this behavior in other projects. There might be some incompatibility/conflict with the added extensions in the "Horse Race" game.

@abchatra abchatra added bug Something isn't working p2 labels Feb 3, 2023
@abchatra abchatra added this to the Hotfix milestone milestone Feb 3, 2023
@kimprice
Copy link
Member Author

kimprice commented Feb 9, 2023

Worked through this race condition with Richard for quite a while yesterday. What's happening is that after hitting "apply" we reload the header to update the palette and then we go back to the asset editor view - but in this case, the headers aren't finished loading by the time the asset editor is open and therefore the temporary assets don't appear.

We tried adding a listener such that when the blocks project DOM is finished updating, the assets gallery will update the user assets, but it didn't fix the problem. The fields still were not being initialized.

Going forward, we will likely need to implement a data subscribe for the palette instead of calling reload header and then opening the asset editor. This approach would also close this issue of flashing to the blocks editor and back to the asset editor: #5496

@kimprice kimprice removed this from the Hotfix milestone milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset editor bug Something isn't working p2
Projects
None yet
Development

No branches or pull requests

2 participants