Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing color palette doesn't take effect on "Planet Putt Putt" #5804

Open
Sheila111 opened this issue Mar 21, 2023 · 4 comments
Open

Changing color palette doesn't take effect on "Planet Putt Putt" #5804

Sheila111 opened this issue Mar 21, 2023 · 4 comments
Assignees
Labels
asset editor bug Something isn't working p2

Comments

@Sheila111
Copy link

Describe the bug
Changing color palette doesn't take effect on "Planet Putt Putt"

Steps to reproduce the behavior

  1. Navigate to https://arcade.makecode.com/beta#
  2. JavaScript Games---->Planet Putt Putt---->JavaScript Open Example
  3. Switch to Assets Editor
  4. Click 'Colors' and change color palette to Grayscale

Actual behavior
Changing color palette doesn't take effect on "Planet Putt Putt"

Expect behavior
Changing color palette takes effect on every game

Screenshot
Changing color palette doesn't take effect on "Planet Putt Putt"
2
Changing color palette takes effect on other game
3

Additional context
1.OS: Windows11
2.arcade version: 1.13.11
3.Microsoft MakeCode version: 8.6.14

@abchatra
Copy link
Contributor

@kimprice interesting bug.

@abchatra abchatra added bug Something isn't working p2 asset editor labels Mar 22, 2023
@kimprice
Copy link
Member

This game uses the color-coded-tilemap extension, so I'm guessing that's causing a conflict.

@abchatra
Copy link
Contributor

Legacy won’t fix

@jwunderl
Copy link
Member

This ones not a bug but there's an improvement we should consider making -- the reason it's not applying the palette is not due to the color-coded-tilemap extension but because it changes the palette at runtime (in https://github.com/microsoft/pxt-arcade/blob/master/docs/javascript-games/planet-putt-putt.md search palette)
image

This one has two that it switches between for title screen and 'gameplay' so it doesn't matter too much, but it's probably worth considering adding a snippet type to docs like

```palette
123456
abcdef
...
```

that would set palette in pxt.json so that we can author simple examples with different palettes that are still 'editable'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset editor bug Something isn't working p2
Projects
None yet
Development

No branches or pull requests

4 participants