Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop melody does not stop all melodies from playing #3350

Closed
microbit-mark opened this issue Aug 21, 2020 · 5 comments
Closed

Stop melody does not stop all melodies from playing #3350

microbit-mark opened this issue Aug 21, 2020 · 5 comments

Comments

@microbit-mark
Copy link
Contributor

If you create multiple melodies in a loop, stop melody does not stop them all playing. In this program, if you shake during the first melody, it stops and then passes back to the next melody to play.

microbit-screenshot

I would expect this program to stop all melodies playing on shake ie not play the second melody.

This reproduces in MakeCode and on the device.

@abchatra
Copy link
Contributor

Play melody is sequential. It is possible, first melody is stopped and the second one starts based on the timing.

@abchatra
Copy link
Contributor

They are not run in background but in foreground.

@microbit-mark microbit-mark changed the title Stop melody does not stop al melodies from playing Stop melody does not stop all melodies from playing Aug 24, 2020
@microbit-mark
Copy link
Contributor Author

The stop melody block seems confusing then. Perhaps the default should be 'Stop melody - current' to indicate that it will stop current melody playing but not 'all'.

@abchatra
Copy link
Contributor

It is stopping all the melody which is running. It can't stop the melody which is going to run in the future.

@abchatra
Copy link
Contributor

You can always start a melody once it is stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants