Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge errors in GitHub when collaborating on a project #5075

Closed
Jaqster opened this issue Jan 27, 2023 · 4 comments · Fixed by microsoft/pxt#9489
Closed

Merge errors in GitHub when collaborating on a project #5075

Jaqster opened this issue Jan 27, 2023 · 4 comments · Fixed by microsoft/pxt#9489

Comments

@Jaqster
Copy link
Member

Jaqster commented Jan 27, 2023

Reported by an Educator -
I created a group assignment in GitHub Classroom using MakeCode Arcade. Students created teams today and were trying to practice pushing & pulling changes.
However, when one group member pushed, they got merge errors, and then it wouldn’t let them go back to their blocks, saying there were issues with the code. Some were able to get to Javascript, but then it wouldn’t convert the code into blocks. Some couldn’t get back to their code at all. This happened with several groups.
image

Here is an example repo where students are not able to merge their PR's https://github.com/RoznaiCSP/u5-collaborative-coding-project-danielabi/pulls

@Jaqster
Copy link
Member Author

Jaqster commented Jan 27, 2023

May be related to microsoft/pxt-arcade#1908

@kroznai
Copy link

kroznai commented Jan 27, 2023

May be related to microsoft/pxt-arcade#1908

After reading that issue, it is 100% related.

How I want MakeCode/GitHub to work:

  • students can work at the same time on the code - i.e. student1 works on function1, student2 works on making sprites or onstart or something
  • then they can push their branches to GitHub and merge the changes

Having to pull your partner's changes before doing anything doesn't allow them to work at the same time, so only one computer can be coding at any point during class, so why use GitHub then instead of something like pair programming?

@kroznai
Copy link

kroznai commented Jan 27, 2023

My TEALS volunteer ( @B4-Bingo ) pointed out that a lot of the time the merge error has to do with the .png files that are created, so he's trying to write a script that ignores that file in the merge.

@abchatra
Copy link
Contributor

@pelikhan fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants