Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom broken if a user zooms in via Ctrl+Scroll as well as Ctrl+Plus #362

Closed
samelhusseini opened this issue Sep 22, 2016 · 7 comments
Closed

Zoom broken if a user zooms in via Ctrl+Scroll as well as Ctrl+Plus #362

samelhusseini opened this issue Sep 22, 2016 · 7 comments
Assignees
@samelhusseini
Labels
bug external bug: monaco monaco editor P3

Comments

@samelhusseini
Copy link
Contributor

samelhusseini commented Sep 22, 2016 •
edited

If I zoom in using Ctrl+Scroll and then try to zoom in using Ctrl+Plus, the zooming behaviour is broken.
@samelhusseini samelhusseini self-assigned this Sep 22, 2016
@samelhusseini
Copy link
Contributor Author

samelhusseini commented Sep 22, 2016 •
edited

microsoft/monaco-editor#196

@abchatra
Copy link
Contributor

@MicrosoftSam This doesn't repro for me. If it doesn't repro for you can you close?

@samelhusseini
Copy link
Contributor Author

Yes, still repro's. Waiting for the Monaco editor to expose EditorZoom.

@abchatra abchatra added the P3 label Dec 10, 2016
@samelhusseini samelhusseini mentioned this issue Jan 12, 2017
Closed
@abchatra
Copy link
Contributor

Fixed?

@samelhusseini
Copy link
Contributor Author

Nope, and this won't be fixed until the monaco editor exposes the EditorZoom object.
I would say we either: live with having this bug around, and knowing that it only really repros if you do both of Zoom with Mouse and Zoom with Keyboard.
or alternately we disabled Zoom with Keyboard, since we already have Zoom buttons on the screen.

@abchatra abchatra reopened this Apr 20, 2017
@samelhusseini
Copy link
Contributor Author

Looks like the monaco editor team doesn't plan to expose the EditorZoom object, closing as won't fix.

@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@samelhusseini samelhusseini

Labels
bug external bug: monaco monaco editor P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abchatra @samelhusseini