Completions don't work for test parameters

[rchiodo]

Example code:

import pytest

@pytest.fixture
def test_fixture() -> List[int]:
    return [4]

def test_func(test_fixture):
      test_fixture. # No completions here

We could probably implement first level completions? If the type is any and its declaration is a parameter, get the type from the extensions?

[erictraut]

I think this is worth considering. Instead of Any, you should check for Unknown, since that's what pyright infers for params with no annotation.

[ciszko]

With the recent VSCode IntelliSense improvements for pytest, I've started searching if it's a bug (at least it looks like a bug for someone from the outside). test_fixture as an argument is properly hinted but then inside of the test it's resolved as Any. I just want to say that this suggested enhancement would be a lifesaver for anyone working extensively with fixtures.

[debonte]

@ciszko, please file a new issue on this and include some sample code to demonstrate the behavior that you want.

[ciszko]

Do I need to create another issue if this one already exists? It's exactly what @rchiodo wrote.
A fixture is hinted as an argument

But then if I were to use it, it's Any

[night-as]

Any progress regarding this issue ? It would be really helpful.

[rchiodo]

@night-as this is waiting for more people to up vote it, so no it's not on our backlog yet.

[rchiodo]

Moving to discussions to hopefully get more visibility.

[matifriaz]

Any update on this issue?

[y2kbugger]

Not just completions, but I think it makes sense to have type checking as well, not sure it that all comes along together within pyright or not

[YakovL]

What are the workarounds you guys currently use for this? I have to admit, it's quite annoying. It's also useful to check the discussion on the Pytest end (I tend to believe it's more of their issue than that of Pylance). I've found a fragile workaround:

@pytest.fixture(name='session_manager')
def get_session_manager():
    return GameSessionsManager()

def test_create_session(session_manager: GameSessionsManager):
    ...

The problem about it is casting the GameSessionsManager type to the argument: once implementation of get_session_manager is changed (say, returns GameSessionsManager | None), things can get broken.

[heejaechang]

latest pylance should now support completion for fixture without explicitly typing parameters.

the grey color type annotation is inlay hint not explicit typing.

[YakovL]

Wow, that's true even without type hint for the argument. However, without type hint it still complains that the param type is unknown. Would be great if that one is handled, too!

[heejaechang]

Those pytest IDE features, such as hover and completion, are best-effort basis and that's why we support them. However, diagnostics are a different story. We will still show those errors if you are using strict mode, and the only way to get rid of them will be by explicitly adding type hints, as you used to.