Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-complete activated by period in f-string #1226

Closed
hudcap opened this issue May 4, 2021 · 2 comments
Closed

auto-complete activated by period in f-string #1226

hudcap opened this issue May 4, 2021 · 2 comments
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@hudcap
Copy link

hudcap commented May 4, 2021

Environment data

  • Language Server version: 2021.4.3
  • OS and version: win32 x64
  • Python version (and distribution if applicable, e.g. Anaconda): 3.9.5 64-bit
  • python.analysis.indexing: undefined
  • python.analysis.typeCheckingMode: basic

Expected behaviour

In an f-string, auto-complete should only activate inside braces.

Actual behaviour

Auto-complete activates when typing a period inside an f-string.

image

Unless there's some significance to a period in an f-string that I'm not aware of?

Logs

Python Language Server Log

Background analysis message: setFileOpened
Background analysis message: markFilesDirty
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
Background analysis message: getSemanticTokens delta
[BG(1)] getSemanticTokens delta previousResultId:1620142513034 at Untitled-1 ...
[BG(1)]   parsing: Untitled-1 (0ms)
[BG(1)]   binding: Untitled-1 (0ms)
[BG(1)] getSemanticTokens delta previousResultId:1620142513034 at Untitled-1 (0ms)
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
Background analysis message: getDiagnosticsForRange
Background analysis message: getDiagnosticsForRange
[FG] parsing: Untitled-1 (0ms)
[FG] binding: Untitled-1 (0ms)
Background analysis message: getSemanticTokens delta
[BG(1)] getSemanticTokens delta previousResultId:1620142522108 at Untitled-1 ...
[BG(1)]   parsing: Untitled-1 (0ms)
[BG(1)]   binding: Untitled-1 (1ms)
[BG(1)] getSemanticTokens delta previousResultId:1620142522108 at Untitled-1 (1ms)
Background analysis message: analyze
[BG(1)] analyzing: Untitled-1 ...
[BG(1)]   checking: Untitled-1 (2ms)
[BG(1)] analyzing: Untitled-1 (2ms)
Background analysis message: resumeAnalysis
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
[FG] completion at Untitled-1:0:12 ...
[FG]   parsing: Untitled-1 (2ms)
[FG]   binding: Untitled-1 (0ms)
[FG] completion at Untitled-1:0:12 [found 189 items] (5ms)
Background analysis message: analyze
[BG(1)] analyzing: Untitled-1 ...
[BG(1)]   parsing: Untitled-1 (0ms)
[BG(1)]   binding: Untitled-1 (0ms)
[BG(1)]   checking: Untitled-1 (2ms)
[BG(1)] analyzing: Untitled-1 (3ms)
Background analysis message: getDiagnosticsForRange
Background analysis message: resumeAnalysis
Background analysis message: getDiagnosticsForRange
Background analysis message: getSemanticTokens delta
[BG(1)] getSemanticTokens delta previousResultId:1620142522554 at Untitled-1 (0ms)
@github-actions github-actions bot added the triage label May 4, 2021
@erictraut
Copy link
Contributor

Thanks for the bug report. This will be fixed in an upcoming release.

@erictraut erictraut added bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version and removed triage labels May 4, 2021
@jakebailey
Copy link
Member

This issue has been fixed in version 2021.5.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202150-5-may-2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

3 participants