Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support egg/zip files #1260

Closed
Syndorik opened this issue May 10, 2021 · 8 comments
Closed

Support egg/zip files #1260

Syndorik opened this issue May 10, 2021 · 8 comments
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@Syndorik
Copy link

Environment data

  • Language Server version: 2021.5.2-pre.1
  • OS and version: Windows
  • Python version (& distribution if applicable, e.g. Anaconda): Conda

Expected behaviour

When I do

conda install -c huggingface transformers

It installs to my environement an eggfile. Autocompletion doesn't work with them, while it works for usual installations

@jakebailey
Copy link
Member

Thanks for the issue; we currently don't support egg/zip files (which python transparently opens). We'd need to add support to open these as directories in our file system abstraction.

@jakebailey
Copy link
Member

Hm, you say egg-link files; those should work already. Can you please include trace logs our template asks for? This would indicate that python isn't giving us the list of paths correctly.

https://github.com/microsoft/pylance-release/blob/main/TROUBLESHOOTING.md#filing-an-issue

@jakebailey
Copy link
Member

(Basically, .egg and .zip aren't yet supported, but .egg-link is something that Python will stick into sys.path which we do use.)

@Syndorik
Copy link
Author

Oh sorry, I'm fairly new to this, so I might have misunderstood egg-link and egg files. I have two files in my site-package:
transformers-4.5.1-py3.8.egg
transformers.pth

Are these supported?

@jakebailey
Copy link
Member

Ah, no, those are plain old egg files (which are just zips). We don't support those quite yet.

@jakebailey jakebailey changed the title Lib installed with conda (egg-link) don't appear Support egg/zip files May 10, 2021
@jakebailey
Copy link
Member

Retitled to match for better tracking.

@Syndorik
Copy link
Author

Ok thanks for your answer!

@savannahostrowski savannahostrowski added the enhancement New feature or request label May 10, 2021
@github-actions github-actions bot removed the triage label May 10, 2021
@jakebailey jakebailey added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Jun 2, 2021
@jakebailey
Copy link
Member

This issue has been fixed in version 2021.6.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202160-2-june-2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

3 participants