Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure "rename" doesn't show as an option on elements that can't be renamed #1418

Closed
luabud opened this issue Jun 9, 2021 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@luabud
Copy link
Member

luabud commented Jun 9, 2021

The issue was originally filed at https://github.com/microsoft/vscode-python/issues/10443 for Jedi. I just opened this here as well to make sure that it doesn't also happen with Pylance 馃槉

cc @savannahostrowski

Steps to reproduce:

  1. In a python file, place cursor on None and try to rename it using F2
  2. See input box
  3. Enter a new name and press enter

Bug

See notification that says No result!

Here's what our builtin js/ts extension shows for this case (we show this before the input appears):

Screen Shot 2020-03-04 at 10 26 29 PM

This is implemented using prepareRename: https://github.com/microsoft/vscode/blob/c0c9e0043ce6133042268f22847021ad9a1ce410/extensions/typescript-language-features/src/features/rename.ts#L34

@heejaechang
Copy link
Contributor

this is a dup - #1360

@heejaechang heejaechang added the duplicate This issue or pull request already exists label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants