Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook colorizing does not show on reload #2897

Closed
judej opened this issue Jun 8, 2022 · 6 comments
Closed

Notebook colorizing does not show on reload #2897

judej opened this issue Jun 8, 2022 · 6 comments
Assignees
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version notebooks

Comments

@judej
Copy link
Contributor

judej commented Jun 8, 2022

Environment data

[Info - 10:23:05 AM] (53292) Pylance language server 2022.6.0 (pyright c6e1d8dd) starting
[Info - 10:23:05 AM] (53292) Server root directory: c:\Users\judej.vscode-insiders\extensions\ms-python.vscode-pylance-2022.6.0\dist
Notebook support: LSP

Code Snippet

Animation

Repro Steps

This repros on Legacy and LSP notebook support. After reloading the window, the colors do not appear until I edit the file and trigger a completion as the GIF shows

Expected behavior

The colors should light up on reload

Logs

The following log entry shows up when I start typing:
(43764) [BG(2)] getSemanticTokens full at c:\Users\judej\source\scratch\pd1\test.ipynb:pylance-notebook-cell:ch0000000 (1ms)

@judej judej added triage needs investigation Could be an issue - needs investigation labels Jun 8, 2022
@github-actions github-actions bot removed the triage label Jun 8, 2022
@judej
Copy link
Contributor Author

judej commented Jun 8, 2022

Are these related?
#2837

@judej judej added the notebooks label Jun 8, 2022
@bschnurr
Copy link
Member

bschnurr commented Jun 9, 2022

adding this to my settings.json

  "python.trace.server": "verbose",

hmm. strange. We seem to be returning a response, but no color update is happening.

[Trace - 2:24:58 PM] Received response 'textDocument/semanticTokens/range - (3)' in 1684ms.
Result: {
    "resultId": "1654809898124",
    "data": [
        0,
        7,
        5,
        16,
        0,
        0,
        9,
        2,
        16,
        0,
        2,
        0,
        1,
        14,
        1,
        0,
        4,
        2,
        16,
        0,
        0,
        3,
        6,
        16,
        0,
        0,
        7,
        7,
        13,
        0
    ]
}

@bschnurr
Copy link
Member

bschnurr commented Jun 9, 2022

full log

missingSemanticTokens.txt

with
"python.pylanceLspNotebooksEnabled": true,

I only see this bug with pylanceLspNotebooksEnabled = true.

[Trace - 2:24:57 PM] Received response 'textDocument/semanticTokens/full - (1)' in 1600ms.
Result: {
    "data": []
}

@bschnurr bschnurr added bug Something isn't working and removed needs investigation Could be an issue - needs investigation labels Jun 9, 2022
@bschnurr
Copy link
Member

bschnurr commented Jun 9, 2022

Not sure why full tokens is empty

@debonte
Copy link
Contributor

debonte commented Jun 9, 2022

@bschnurr, if you can repro this, could you try reproing with this extra logging that I created for Rich? https://github.com/debonte/pyrx/commit/e97106d778367d1835812ba9bb78d1bfe2f1aa33

The issue stopped reproing for him when I gave him this change and I've never been able to repro it.

@debonte debonte assigned debonte and unassigned bschnurr Aug 24, 2022
@debonte debonte added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Aug 25, 2022
@bschnurr
Copy link
Member

bschnurr commented Sep 1, 2022

This issue has been fixed in version 2022.8.51, which we've just released. You can find the changelog here: CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version notebooks
Projects
None yet
Development

No branches or pull requests

3 participants