Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default typing folder no longer respected #326

Closed
judej opened this issue Sep 4, 2020 · 2 comments
Closed

default typing folder no longer respected #326

judej opened this issue Sep 4, 2020 · 2 comments
Assignees
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@judej
Copy link
Contributor

judej commented Sep 4, 2020

  • Language Server version: Pylance language server 2020.9.0 (pyright 60eb2cca)
  • OS and version: Windows 10
  • Python version 3.8.5

Expected behaviour

If I create a stub in the ./typings (default) folder, it Pylance should discover it.

Actual behaviour

The type stubs I add are not found.

However, if in the setting UI, it set the
"Python > Analysis: Stub Path" to blank, it works

@github-actions github-actions bot added the triage label Sep 4, 2020
@jakebailey
Copy link
Member

Broken by the fix to #285, the default value is somehow being treated differently even though under the hood is "if not provided, say 'typing'".

@jakebailey jakebailey added the bug Something isn't working label Sep 4, 2020
@github-actions github-actions bot removed the triage label Sep 4, 2020
@jakebailey jakebailey self-assigned this Sep 14, 2020
@jakebailey jakebailey added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Sep 22, 2020
@jakebailey
Copy link
Member

This issue has been fixed in version 2020.9.6, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#202096-23-september-2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

2 participants