Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic highlighting broken #3667

Closed
parched opened this issue Nov 23, 2022 · 4 comments
Closed

Semantic highlighting broken #3667

parched opened this issue Nov 23, 2022 · 4 comments
Labels
fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@parched
Copy link

parched commented Nov 23, 2022

Environment data

  • Language Server version: Pylance language server 2022.11.32 (pyright 45344736)
  • OS and version: Windows 10
  • Python version (& distribution if applicable, e.g. Anaconda): python 3.10

Code Snippet

image

It looks like it's using the wrong line
image

is actually the highlighting for this line in the same file
image

This part of large multi root workspace so I don't have a small reproducer yet unfortunately.

These are the logs that refer to the file, is there anything else in the logs I should look out for?

[Info  - 4:06:32 pm] (17668) [BG(18)] Long operation: getSemanticTokens full at path/to/file.py (5427ms)
[Info  - 4:06:44 pm] (17668) [BG(18)] Long operation: checking: path/to/file.py (2395ms)
[Info  - 4:06:44 pm] (17668) [BG(18)] Long operation: analyzing: path/to/file.py (2656ms)
(17668) [BG(12)] analyzing: path/to/file.py ...
(17668) [BG(12)]   parsing: path/to/file.py (55ms)
(17668) [BG(12)]   binding: path/to/file.py (1ms)
(17668) [BG(12)]   checking: path/to/file.py ...
(17668) [BG(12)]   checking: path/to/file.py (1015ms)
(17668) [BG(12)] analyzing: path/to/file.py (1684ms)
(17668) [BG(18)] analyzing: path/to/file.py ...
(17668) [BG(18)]   parsing: path/to/file.py (160ms)
(17668) [BG(18)]   binding: path/to/file.py (3ms)
(17668) [BG(18)]   checking: path/to/file.py ...
(17668) [BG(12)] indexing: path/to/file.py [found 6] (0ms)
(17668) Indexing Done: path/to/file.py
(17668) [FG] parsing: path/to/file.py (66ms)
(17668) [FG] binding: path/to/file.py (2ms)
(17668) [BG(18)]   checking: path/to/file.py (2959ms)
[Info  - 4:16:21 pm] (17668) [BG(18)] Long operation: checking: path/to/file.py (2959ms)
(17668) [BG(18)] analyzing: path/to/file.py (3286ms)
[Info  - 4:16:21 pm] (17668) [BG(18)] Long operation: analyzing: path/to/file.py (3286ms)
@parched
Copy link
Author

parched commented Nov 23, 2022

Potentially duplicate of #3649. Rolling back to v2022.11.20 seems to have fixed it.

@bschnurr
Copy link
Member

bschnurr commented Nov 23, 2022

This might be related to this issue. fix coming in next week's pre-release.
#3652

@heejaechang
Copy link
Contributor

he meant next release which is next week.

@judej judej added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Nov 28, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Nov 30, 2022

This issue has been fixed in prerelease version 2022.11.41, which we've just released. You can find the changelog here: CHANGELOG.md

@rchiodo rchiodo closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

5 participants