Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use a modified build of Pyright with Pylance? #377

Closed
xSetech opened this issue Sep 16, 2020 · 1 comment
Closed

How to use a modified build of Pyright with Pylance? #377

xSetech opened this issue Sep 16, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@xSetech
Copy link

xSetech commented Sep 16, 2020

Is it possible to integrate modifications to Pyright with Pylance? There's a static typing issue I'm running into for which I have a patch, but there are no apparent instructions on how to test the change with Pylance. On the other hand, Pyright has plenty of documentation on how to build and test; but I do not have Pyright installed as an extension. It'd be helpful if the readme addressed how modifications to Pyright can be tested in the context of an installed Pylance.

@jakebailey
Copy link
Member

This is probably a dupe of #33, but with the way Pylance is designed and distributed, it's not currently possible to do something like this.

If you're changing something to do with static typing in general, I would recommend working in the context of pyright, as we pull changes from there and things that are more type-check specific are better reported there. I recently refactored that repo to make it more straightforward to test changes with the type checker and extension, so if you disable Pylance and just follow their instructions you should be able to test your changes.

I'm not sure what the benefit of running it within pylance would be, but if you think there's something specific where running pyright alone is not enough, I'd be curious to know what that is.

@jakebailey jakebailey added the duplicate This issue or pull request already exists label Sep 16, 2020
@github-actions github-actions bot removed the triage label Sep 16, 2020
@huguesv huguesv closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants