Auto-indent behavior as before / jumping to beginning of line

[amueller]

Filing as requrested in microsoft/vscode-python#481

Environment data

• Language Server version: v2022.12.20
• [Info - 5:13:28 PM] (8596) Pylance language server 2022.12.20 (pyright 621d886b) starting
• OS and version: Windows / WSL
• Python version (& distribution if applicable, e.g. Anaconda): Python 3.8.13 via anaconda

Code Snippet

def f(a,<newline>

jumps to the beginning of the next line, instead of to the opening parenthesis indentation.
Same in similar settings (calling a function, in an if clause, ...), and also if the parenthesis is closed.

I added the languageServer line and the "editor.formatOnType": true, but still see the linebreak behavior issues.
Is there a way to confirm I set it up correctly?

[rchiodo]

I believe this is on purpose. Until the function has a : on the end, it's not considered a function. Auto indentation only happens once it's known to be a function (or an if statement, etc).

This works:

def f(a):<newline>

But this doesn't:

def f(a)<newline>

[amueller]

please note that there is no closing parenthesis in my example, meaning the next token would be a second argument for the function, not the function body.

[rchiodo]

This does seem silly. Why would it not indent to the parens. PEP 8 seems to indicate a different default than jumping to the ( though:

https://peps.python.org/pep-0008/#indentation

Maybe that's just an example though.

If we were to implement this would it need settings?

[amueller]

My reading (and I think what flake8 and pep8 enforce?) is that if there is nothing after the opening parenthesis (handing indent), we indent an extra level, if there is already something after the opening parenthesis (first example), then indent to the opening delimiter.

[heejaechang]

This issue has been fixed in prerelease version 2023.1.21, which we've just released. You can find the changelog here: CHANGELOG.md