Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylance's inlay hints to pyright? #4169

Closed
FrancescElies opened this issue Mar 30, 2023 · 2 comments
Closed

pylance's inlay hints to pyright? #4169

FrancescElies opened this issue Mar 30, 2023 · 2 comments
Assignees

Comments

@FrancescElies
Copy link

I am well aware that this question might be closed directly because of this being answered in faq

Because we have plans to include Pylance in Microsoft products outside of VS Code that do not have the same license, business models and/or are closed-source (for example, fully managed products and services), we do not currently have plans to open-source Pylance.

However, a substantial portion of Pylance’s source code is open source via the Pyright type checker. We welcome contributions via that repository, and feedback on Pylance via our pylance-release repo.

I still would like to hear what you think specifically about inlay hints being part of pyright instead of pylance. Lsp support for inlayhints was introduced into the protocol and many implementations out there like rust-analyzer and typescript-language-server offer inlayhints that can be enabled in any editor supporting lsp.

Vscode is great, I feel making that opensource wouldn't make people go away from vscode into other editors but it feels a bit weird that on one side microsoft's lsp open specification has support for inlay hints but the actual implementation for python is locked into a vscode extension instead of being open.

In short, are there any chances we would see microsoft shifting ground and making this part of pyright?

@rchiodo
Copy link
Contributor

rchiodo commented Mar 30, 2023

Sorry I don't think that's likely to happen. These issues are useful in gauging how many people wouldn't use Pylance because it's not open source though.

@rchiodo rchiodo closed this as completed Mar 30, 2023
@FrancescElies
Copy link
Author

@rchiodo thanks for your reply.

That's unfortunate, but I guess it is what it is.

At least pyright implements textDocument/hover allowing to ask any editor to ask the type for specific variables and reveal_type from typing is always at hand too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants