Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic token not refreshing on file watcher notification #5193

Closed
heejaechang opened this issue Dec 1, 2023 · 2 comments
Closed

semantic token not refreshing on file watcher notification #5193

heejaechang opened this issue Dec 1, 2023 · 2 comments
Assignees
Labels
needs repro Issue has not been reproduced yet

Comments

@heejaechang
Copy link
Contributor

heejaechang commented Dec 1, 2023

pylance is not sending refresh requests on file change notification from file watcher

see this (https://github.com/microsoft/pyrx/blob/8abca756d37995387d88853c21913a1f09cb6695/packages/pylance-internal/src/server/asyncServer.ts#L705C9-L711C10)

            this.connection.sendRequest(SemanticTokensRefreshRequest.method).ignoreErrors();
            this.connection.sendRequest(InlayHintRefreshRequest.method).ignoreErrors();

one can repro it using
https://github.com/microsoft/pylance-release/blob/0945dea30d3276dcf945543aa4f5f75c84aa4136/testing/single/src/fileWatcher.py#L4C1-L6C24

@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Dec 1, 2023
@bschnurr bschnurr assigned bschnurr and unassigned bschnurr Jan 4, 2024
@bschnurr bschnurr closed this as completed Jan 8, 2024
@bschnurr
Copy link
Member

bschnurr commented Jan 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs repro Issue has not been reproduced yet
Projects
None yet
Development

No branches or pull requests

3 participants