Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't append "py" on show call hierarchy view when source is a notebook file #5815

Closed
luabud opened this issue Apr 27, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@luabud
Copy link
Member

luabud commented Apr 27, 2024

Environment data

  • Language Server version: 2024.4.104
  • OS and version: linux x64 (Codespaces)
  • Python version (and distribution if applicable, e.g. Anaconda): Python 3.10.13, venv
  • python.analysis.indexing: true
  • python.analysis.typeCheckingMode: basic

Code Snippet

Open a notebook file and add the following:


class Class:
    # Single-line ranges (such as single-line functions) are not foldable.
    def singleLineFunction(self): pass

    def function1(self, name: str, address: str, title: str):
        # Multiline strings can be folded, leaving only the first line visible.
        """Doc string
        Doc string
        """
        pass

Class().function1("", "", "")

Then right click on function1 at the last line and trigger "Show Call Hierarchy". Notice how the notebook file shows on the callers view with .py appended to it

image

@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Apr 27, 2024
@debonte debonte added bug Something isn't working and removed needs repro Issue has not been reproduced yet labels Apr 27, 2024
@debonte
Copy link
Contributor

debonte commented Apr 27, 2024

Type hierarchy also has this issue:
image

This is a slight improvement over these issues tracking the old behavior. I'll close them:

@debonte debonte added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label May 1, 2024
@KacieKK
Copy link
Contributor

KacieKK commented May 9, 2024

This issue has been fixed in prerelease version 2024.5.100, which we've just released. You can find the changelog here: CHANGELOG.md

@KacieKK KacieKK closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

3 participants