Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying intellisense: showing me parameter popup during editing str parameter #5977

Open
ibobak opened this issue Jun 6, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@ibobak
Copy link

ibobak commented Jun 6, 2024

Type: Bug

Behaviour

image

Steps to reproduce:

See the video: https://youtu.be/Z-qQhagODcc

Diagnostic data

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

XXX

Extension version: 2024.8.0
VS Code version: Code 1.90.0 (89de5a8d4d6205e5b11647eb6a74844ca23d2573, 2024-06-04T19:43:07.605Z)
OS version: Linux x64 6.4.6-060406-generic
Modes:

  • Python version (& distribution if applicable, e.g. Anaconda): 3.10.14
  • Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
  • Value of the python.languageServer setting: Pylance
User Settings


languageServer: "Pylance"

Installed Extensions
Extension Name Extension Id Version
.NET Install Tool ms-dotnettools.vscode-dotnet-runtime 2.0.5
autoDocstring - Python Docstring Generator njpwerner.autodocstring 0.6.1
Ayu Monokai lakshits11.ayu-monokai 0.0.3
Black Formatter ms-python.black-formatter 2024.2.0
C# ms-dotnettools.csharp 2.31.19
C# Dev Kit ms-dotnettools.csdevkit 1.6.8
Checkpoints micnil.vscode-checkpoints 1.3.3
Code Runner formulahendry.code-runner 0.12.2
Conventional Commits vivaxy.vscode-conventional-commits 1.25.0
Data Wrangler ms-toolsai.datawrangler 1.2.0
Dev Containers ms-vscode-remote.remote-containers 0.369.0
Django batisteo.vscode-django 1.15.0
Docker ms-azuretools.vscode-docker 1.29.1
Docs View bierner.docs-view 0.1.0
Edit csv janisdd.vscode-edit-csv 0.9.1
Git Extension Pack donjayamanne.git-extension-pack 0.1.3
Git Extension Pack (GPack) SeyyedKhandon.gpack 2.0.0
Git File History pomber.git-file-history 1.0.1
Git History donjayamanne.githistory 0.6.20
Github Light Theme Hyzeta.vscode-theme-github-light 7.14.2
GitHub Plus Theme thenikso.github-plus-theme 1.4.3
GitHub Theme GitHub.github-vscode-theme 6.3.4
gitignore codezombiech.gitignore 0.9.0
GitLens — Git supercharged eamodio.gitlens 15.0.4
Grey Light+ Pro elanzalaco.grey-light-plus-pro 0.0.1
IntelliCode VisualStudioExptTeam.vscodeintellicode 1.3.1
IntelliCode API Usage Examples VisualStudioExptTeam.intellicode-api-usage-examples 0.2.8
IntelliCode for C# Dev Kit ms-dotnettools.vscodeintellicode-csharp 2.1.11
JavaScript Debugger ms-vscode.js-debug 1.90.0
JavaScript Debugger Companion Extension ms-vscode.js-debug-companion 1.1.2
Jinja wholroyd.jinja 0.0.8
julia light JuliaLight.julia-light 0.4.0
Jupyter ms-toolsai.jupyter 2024.5.0
Jupyter Cell Tags ms-toolsai.vscode-jupyter-cell-tags 0.1.9
Jupyter Keymap ms-toolsai.jupyter-keymap 1.1.2
Jupyter Notebook Renderers ms-toolsai.jupyter-renderers 1.0.17
Jupyter Slide Show ms-toolsai.vscode-jupyter-slideshow 0.1.6
Jupyter Theme sam-the-programmer.jupyter-theme 0.1.3
JupyterLab Light Theme MiguelCorralJr.jupyterlab-light-theme 0.1.1
Light Pink Theme mgwg.light-pink-theme 0.6.0
Markdown All in One yzhang.markdown-all-in-one 3.6.2
Markdown Preview Enhanced shd101wyy.markdown-preview-enhanced 0.8.13
MZ Light Grey Theme Malaz-YI.mz-light-grey 2.1.1
Night Owl sdras.night-owl 2.0.1
Notepad++ color themes ShayanAhmedKhan.notepadpp-color-theme 0.2.0
Numbered Bookmarks alefragnani.numbered-bookmarks 8.4.0
One Dark Pro zhuangtongfa.material-theme 3.17.2
One Dark Theme mskelton.one-dark-theme 1.14.2
Open in GitHub, Bitbucket, Gitlab, VisualStudio.com ! ziyasal.vscode-open-in-github 1.3.6
Path Intellisense christian-kohler.path-intellisense 2.9.0
Project Manager alefragnani.project-manager 12.8.0
Pylance ms-python.vscode-pylance 2024.5.1
Pylint ms-python.pylint 2023.10.1
Python ms-python.python 2024.6.0
Python Debugger ms-python.debugpy 2024.6.0
Python Environment Manager donjayamanne.python-environment-manager 1.2.4
Python Extension Pack donjayamanne.python-extension-pack 1.7.0
Python Indent KevinRose.vsc-python-indent 1.18.0
Remote - SSH ms-vscode-remote.remote-ssh 0.110.1
Remote - SSH: Editing Configuration Files ms-vscode-remote.remote-ssh-edit 0.86.0
Remote - Tunnels ms-vscode.remote-server 1.5.1
Remote Development ms-vscode-remote.vscode-remote-extensionpack 0.25.0
Remote Explorer ms-vscode.remote-explorer 0.4.3
Studio Icons jtlowe.vscode-icon-theme 1.6.6
Table Visualizer for JavaScript Profiles ms-vscode.vscode-js-profile-table 1.0.9
Visual Studio Keymap ms-vscode.vs-keybindings 0.2.1
WSL ms-vscode-remote.remote-wsl 0.88.2
Zoomer anthonyattard.zoomer 0.3.1
System Info
Item Value
CPUs Intel(R) Xeon(R) CPU E5-2696 v4 @ 2.20GHz (88 x 1199)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) 1, 2, 2
Memory (System) 251.76GB (166.61GB free)
Process Argv --crash-reporter-id 27d42247-63fb-4d9e-9cb0-87d9974843dc
Screen Reader no
VM 50%
DESKTOP_SESSION ubuntu-xorg
XDG_CURRENT_DESKTOP Unity
XDG_SESSION_DESKTOP ubuntu-xorg
XDG_SESSION_TYPE x11
A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
jchc7451:31067544
chatpanelt:31048053
dsvsc021:30996838
9c06g630:31013171
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31061160
pythonprt:31056678
dwnewjupyter:31046869
26j00206:31048877

@karthiknadig karthiknadig transferred this issue from microsoft/vscode-python Jun 6, 2024
@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Jun 6, 2024
@heejaechang
Copy link
Contributor

sounds like same bug as #5965 (comment)

issue seems code that detect signature help position doesn't consider being in the string literal.

@heejaechang heejaechang added bug Something isn't working and removed needs repro Issue has not been reproduced yet labels Jun 10, 2024
@ibobak
Copy link
Author

ibobak commented Jun 11, 2024

One more scenario:

image

image

image

I would not show those popups inside strings UNLESS I am typing in something in {} inside the f-string.

@ibobak
Copy link
Author

ibobak commented Jun 11, 2024

@heejaechang, may I ask you, how to avoid automatic popups in the jupyter notebooks? I tried option "editor.hover.enabled": false, but it looks like it is not applicable to the notebooks.

Thanks in advance.

image

@ibobak
Copy link
Author

ibobak commented Jun 11, 2024

Looks like I've found answer to my previous question:

"editor.parameterHints.enabled": false

Problem solved for me: if I want them to be shown, I will explicitly press Ctrl+Shift+Space.

But anyway, in general case it is worth to be solved so that it will not popup while I am editing a string.

@ibobak
Copy link
Author

ibobak commented Jun 12, 2024

@heejaechang Could you please look at one more thing? https://youtu.be/RgnYR0QbjCY

The popup is different (this is not that yellow one, but the one which offers parameters). And the setting editor.parameterHints.enabled=false doesn't help that.

@ibobak
Copy link
Author

ibobak commented Jun 18, 2024

@heejaechang and one more case: https://www.youtube.com/watch?v=W22HhLPnsLk

To summarize what is in this video:

  • if I have an f string like f"{}" and I want to insert something between {} - I do need a popup.
  • I I have a plain string, I don't need any popups shown when my cursor is in the middle.

@heejaechang
Copy link
Contributor

@heejaechang Could you please look at one more thing? https://youtu.be/RgnYR0QbjCY

The popup is different (this is not that yellow one, but the one which offers parameters). And the setting editor.parameterHints.enabled=false doesn't help that.

this is completion, not signature help, that's why the option didn't help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants