Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch version #53

Closed
shatu opened this issue Jul 8, 2021 · 3 comments · Fixed by #62
Closed

PyTorch version #53

shatu opened this issue Jul 8, 2021 · 3 comments · Fixed by #62
Labels
question Further information is requested

Comments

@shatu
Copy link
Collaborator

shatu commented Jul 8, 2021

What PyTorch version does the latest PyMarlin release support? Since PyTorch has a fairly frequent release cycle with plenty of breaking changes, it would be good to specify the lower and upper bounds of the PyTorch version the PyMarlin library can support.

@jsleep
Copy link
Contributor

jsleep commented Aug 10, 2021

That's a great question, I believe we've tested with PyTorch1.3-1.9 in our team - the day that PyTorch move 2.0+ there may be some breaking change that we need to adapt to

@jsleep jsleep added the question Further information is requested label Aug 10, 2021
@shatu
Copy link
Collaborator Author

shatu commented Aug 18, 2021

I see. Maybe we should then update the DockerFile to reflect this. Currently, it'll fetch the most recent version of PyTorch, which might start breaking things with newer versions of PyTorch.

@jsleep
Copy link
Contributor

jsleep commented Sep 2, 2021

we don't even really use that Dockerfile but may be I can add torch<=1.9 in the required deps setup.py, pymarlin depends completely on pytorch being installed and we should have some strict dependency on it (even if it hasn't been installed yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants