Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyright-langserver as a TCP server? #3932

Closed
Dronte opened this issue Sep 12, 2022 · 1 comment
Closed

Pyright-langserver as a TCP server? #3932

Dronte opened this issue Sep 12, 2022 · 1 comment
Labels
as designed Not a bug, working as intended enhancement request New feature or request

Comments

@Dronte
Copy link

Dronte commented Sep 12, 2022

I understand that this issue is mostly related to vscode-languageserver but since pyright is the end product I'm trying to use I'm posting the issue here.

The behavior of --socket argument is wired. First it accepts port number, not path to a socket.

Second this port number is a port where client listens . On start this port sends a couple of messages then it just listens to initialize request. If there is nobody listening on that port, the server exists. I see no reason on this behaviour. These messages are not needed to the client, it can send initialise request without them. Additionally, it makes the only order that client and server must be started - first client, bind to port, and then provide this port to the server.

I see no reason, why this order can't be reversed - first run the server, make it listen on some port, then tell the client which port to connect to. And It gives the client an ability to reconnect to the server without restarting it. Isn't it much simpler way than making the client responsible to behave like a server?

@Dronte Dronte added the enhancement request New feature or request label Sep 12, 2022
@erictraut
Copy link
Collaborator

As you said, this is related to vscode-languageserver, not pyright. We have no plans to change this.

@erictraut erictraut added the as designed Not a bug, working as intended label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
as designed Not a bug, working as intended enhancement request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants