Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor drivers HP -> Ithaco #6114

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented May 23, 2024

  • Convert all drivers HP -> Ithaco to new add_parameter format.
  • Don't document inherited attributes

TODO

  • News fragment

@jenshnielsen jenshnielsen requested a review from a team as a code owner May 23, 2024 14:10
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 67.53%. Comparing base (10785d5) to head (c7851c9).
Report is 9 commits behind head on main.

Files Patch % Lines
src/qcodes/instrument_drivers/HP/HP_8753D.py 0.00% 24 Missing ⚠️
src/qcodes/instrument_drivers/HP/HP_8133A.py 0.00% 18 Missing ⚠️
src/qcodes/instrument_drivers/HP/HP_83650A.py 0.00% 18 Missing ⚠️
src/qcodes/instrument_drivers/Harvard/Decadac.py 0.00% 18 Missing ⚠️
...rc/qcodes/instrument_drivers/ithaco/Ithaco_1211.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6114      +/-   ##
==========================================
- Coverage   67.63%   67.53%   -0.10%     
==========================================
  Files         352      352              
  Lines       30746    30790      +44     
==========================================
  Hits        20795    20795              
- Misses       9951     9995      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue May 24, 2024
Merged via the queue into microsoft:main with commit dbb23fc May 24, 2024
18 of 20 checks passed
@jenshnielsen jenshnielsen deleted the hp_refactor branch May 24, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants