Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keysight refactor #6125

Merged
merged 30 commits into from
May 28, 2024
Merged

Keysight refactor #6125

merged 30 commits into from
May 28, 2024

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented May 27, 2024

Refactor Keysight drivers to include attributes for parameters and make Base classes public for documentation

  • News fragment

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 79.39297% with 129 lines in your changes are missing coverage. Please review.

Project coverage is 67.59%. Comparing base (b413de0) to head (f09c13d).

Files Patch % Lines
src/qcodes/instrument_drivers/Keysight/N52xx.py 12.65% 69 Missing ⚠️
...des/instrument_drivers/Keysight/Keysight_B2962A.py 5.26% 18 Missing ⚠️
src/qcodes/instrument_drivers/Keysight/KtMAwg.py 6.66% 14 Missing ⚠️
src/qcodes/instrument_drivers/Keysight/N51x1.py 33.33% 14 Missing ⚠️
src/qcodes/instrument_drivers/Keysight/KtM960x.py 0.00% 13 Missing ⚠️
...rc/qcodes/instrument_drivers/Keysight/Infiniium.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6125      +/-   ##
==========================================
+ Coverage   67.48%   67.59%   +0.10%     
==========================================
  Files         352      352              
  Lines       31181    31486     +305     
==========================================
+ Hits        21044    21284     +240     
- Misses      10137    10202      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen marked this pull request as ready for review May 28, 2024 07:54
@jenshnielsen jenshnielsen requested a review from a team as a code owner May 28, 2024 07:54
@jenshnielsen jenshnielsen added this pull request to the merge queue May 28, 2024
Merged via the queue into microsoft:main with commit e5f0a7b May 28, 2024
20 checks passed
@jenshnielsen jenshnielsen deleted the keysight_refactor branch May 29, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants