Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compilerRunTimeoutMs a configurable setting (for VSCode extension) #1667

Open
spencerdearman opened this issue Jun 25, 2024 · 1 comment
Labels
enhancement New feature or request needs triage

Comments

@spencerdearman
Copy link

Is your feature request related to a problem? Please describe.
I am trying to run a more complex quantum circuit that requires a timeout for the variable compilerRunTimeoutMs greater than 5 minutes. It would be really nice if this would be configurable such that the estimator could run longer when using the VSCode extension.

Describe the solution you'd like
When running the estimator, perhaps you could pass in an optional argument for compilerRunTimeoutMs. I included a little code snippet of what this could look like:

results = qsharp.estimate( "Testing.TestToRun()", "compilerRunTimeoutMs": **input here** )

Describe alternatives you've considered
I built the package from source and I edited the locations of compilerRunTimeoutMs to get the result I wanted but it is a bad solution and not as simple as it could be.

@spencerdearman spencerdearman added enhancement New feature or request needs triage labels Jun 25, 2024
@billti
Copy link
Member

billti commented Jul 10, 2024

I played around with adding this and hit some other issues. Basically, for any action that spins up both a webview and a compiler worker to do the work for it (resource estimation, histogram, circuit visualization, etc.), if the user closes the webview panel before it's done running, that should cancel/terminate the worker.

With that in mind, we probably don't need a timeout at all in these scenarios. We should just let it run and the user can just close the in-progress panel if they want to cancel. Fixing some of the issues here and using this approach might be cleaner than adding new timeout settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

2 participants