Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Update Broombridge and chemistry library for UCC state preparation. #51

Closed
guanghaolow opened this issue Apr 2, 2019 · 1 comment
Closed

Update Broombridge and chemistry library for UCC state preparation. #51

guanghaolow opened this issue Apr 2, 2019 · 1 comment
Assignees
@guanghaolow
Labels
Kind-Enhancement New feature or request
Milestone
May 2019

Comments

@guanghaolow
Copy link
Contributor

guanghaolow commented Apr 2, 2019 •
edited

Broombridge:

  • Add UCC state preparation description
  • Reduce number of mandatory fields that are not used.
  • Clarify how various fields are used

Chemistry library:

  • Add UCC state preparation method
  • Minor restructuring to improve code reusability.

Specific tasks:

  • In UnitaryCCWavefunction.cs of gulow/GenericLadderOperatos , we have the comment

// This class is for Fermion terms that are not grouped into Hermitian bunches.
// Maybe need a stype for quantum state?

// For now, UCC is a subclass of MCF. It should eventually be a Hamiltonian
// + a WavefunctionSCF.

Other tasks:
Modify Broombridge MCF to have a reference state that is not always the vacuum state #66 (comment)
@guanghaolow guanghaolow self-assigned this Apr 2, 2019
@guanghaolow guanghaolow added the Kind-Enhancement New feature or request label Apr 2, 2019
@cgranade cgranade added this to the On Deck milestone Apr 2, 2019
@guanghaolow
Copy link
Contributor Author

guanghaolow commented Apr 11, 2019 •
edited

Addressed in #58,

@guanghaolow guanghaolow reopened this Apr 11, 2019
@guanghaolow guanghaolow mentioned this issue Apr 11, 2019
Closed
@guanghaolow guanghaolow reopened this Apr 11, 2019
@cpalmer2020 cpalmer2020 modified the milestones: On Deck, May 2019 Apr 12, 2019
@guanghaolow guanghaolow mentioned this issue May 17, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@guanghaolow guanghaolow

Labels
Kind-Enhancement New feature or request
Projects
None yet
Milestone
May 2019
Development

No branches or pull requests
3 participants
@cgranade @guanghaolow @cpalmer2020