New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot build on RN 0.62 #1822
Comments
same issue |
Same issue also here |
Hi @marf , Try to add the following additions to your
We are investigating this issue now, let me know if this helped you. |
Hello @andreidubov,
Thank you |
Same issue :( |
@andreidubov even after applying your solution, i am getting the same error found in issue #1823 . Any update on when this will be resolved? |
Quick update. By applying: below:
in since I have read that with Rn 0.62 Fast Refresh has been enabled by default and replaced hot reload. This is clearly a workaround and we are waiting for the official fix. Hope this helps. |
@marf Thanks for the update. I'm about to try and will give feedback on whether or not it works for me. I'm in the middle of bootstrapping a clean version of RN 0.62 |
My project uses RN 0.62.0 @marf for me, following the instructions for RN >= 0.60 for Android I get these errors:
Here were my steps afterwards:
rootProject.name = 'HailTrace'
apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings)
include ':app', ':react-native-code-push'
project(':react-native-code-push').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-code-push/android/app') After trying to build, I received this error:
isLiveReloadEnabled = devInternalSettings.isHotModuleReplacementEnabled(); It used to be: isLiveReloadEnabled = devInternalSettings.isReloadOnJSChangeEnabled();
|
The solution posted by @AustinHunt above worked for me. |
To patch this for now, I added this to my yarn's postinstall so it doesn't break other users' code on my team: sed -i -e "s/isReloadOnJSChangeEnabled/isHotModuleReplacementEnabled/g" "node_modules/react-native-code-push/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java" |
This is a nice solution. I've found it semi-frustrating every time I install a new yarn module to need to replicate step 3. |
solved in #1829 |
@lukebars is there anything we need to change besides updating the code push version? I'm still getting the error even after #1829 upgrade
|
Hi all, As @lukebars mentioned, #1829 solved this issue and we made new release: https://github.com/microsoft/react-native-code-push/releases/tag/v6.2.0 @bgold0, Please check the updated docs setup section: https://github.com/microsoft/react-native-code-push/blob/master/docs/setup-android.md#plugin-installation-and-configuration-for-react-native-060-version-and-above-android I'm going to close this issue for now. Please feel free to reopen it if you have any questions. |
@alexandergoncharov This has always been in my
|
Have you updated your |
I did with 4 steps as the docs guide, but it doesn't work with rn0.62
|
Doest work for me either |
Try with #1831 (comment), it worked for me ! |
That worked for me too .. I had to change from this
to (notice I've moved the code-push line BELOW the
|
@alexandergoncharov, not sure what you mean by "solved this" when, on RN 0.62 and RNCodePush 0.62, we have to manually add the changes suggested in this and the related issue? I would assume solving the issue would mean having autolinking working? |
@madandrija if you want autolinking you just need this in your
But I agree that this should be fixed on a package level, and we shouldn't have to do this manual work |
Hello By adding ths: after this line: in your import com.microsoft.codepush.react.CodePush; and this in ReactNativeHost function: @OverRide in your
in your hopefully, it will work for u as well thanks |
apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings) include ':app', ':react-native-code-push' put these line at bottom of settings.gradle..it worked for me |
Hello,
when I try to build an app based on RN 0.62 and using latest version of CodePush I get this error:
How can this be fixed?
Thank you,
Marco
The text was updated successfully, but these errors were encountered: